From: Paolo Bonzini <pbonzini@redhat.com>
To: qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] Do you have a use for a tester of virtio-scsi with CD drives ?
Date: Wed, 02 Nov 2011 20:50:54 +0100 [thread overview]
Message-ID: <j8s6uv$jik$1@dough.gmane.org> (raw)
In-Reply-To: <97443364817519@192.168.2.69>
On 11/02/2011 07:05 PM, Thomas Schmitt wrote:
>> > The page length is indeed 18 for IDE and 20 for SCSI. I made some changes
>> > to that page recently, but left the 18 because I feared causing regression.
>> > But if that is a bug, we can probably fix it in 1.0.
> This riddles me.
> In hw/scsi-disk.c:mode_sense_page() i see that the page 0x2A
> (now MODE_PAGE_CAPABILITIES) gets filled with 22 bytes, compliant
> to MMC-1. (Later MMCs have longer minimum sizes.)
Ok, in your counting I should have written 20 for IDE (0x12 + page
number + page size) and 22 for SCSI (0x14 + page number + page size).
> But libburn receives only 20 of them, because the Page Length
> is reported as 0x12 in the 10th byte of the reply:
> MODE SENSE
> 5a 00 2a 00 00 00 00 00 1c 00
> From drive: 28b
> 00 22 70 00 00 00 00 00 2a 12 00 00 71 60 29 00 02 c2 00 02
> 02 00 02 c2 00 00 00 00
> Nevertheless i see in hw/scsi-disk.c
> p[1] = 0x14;
> So how is this altered to 0x12 in the further course of processing ?
Because you're using an *IDE* (ATAPI) CD-ROM, not SCSI. See hw/ide/atapi.c.
Paolo
next prev parent reply other threads:[~2011-11-02 19:51 UTC|newest]
Thread overview: 45+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-11-01 17:27 [Qemu-devel] Do you have a use for a tester of virtio-scsi with CD drives ? Thomas Schmitt
2011-11-01 21:03 ` Thomas Schmitt
2011-11-02 11:25 ` Stefan Hajnoczi
2011-11-02 12:08 ` Paolo Bonzini
2011-11-02 16:26 ` Thomas Schmitt
2011-11-02 16:34 ` Paolo Bonzini
2011-11-02 18:05 ` Thomas Schmitt
2011-11-02 19:50 ` Paolo Bonzini [this message]
2011-11-02 21:22 ` Thomas Schmitt
2011-11-02 22:08 ` Thomas Schmitt
2011-11-02 22:16 ` [Qemu-devel] Compile error Frans de Boer
2011-11-02 22:19 ` Anthony Liguori
2011-11-02 22:31 ` Frans de Boer
2011-11-03 7:49 ` [Qemu-devel] Do you have a use for a tester of virtio-scsi with CD drives ? Paolo Bonzini
2011-11-03 9:15 ` Thomas Schmitt
2011-11-03 9:36 ` Paolo Bonzini
2011-11-03 13:10 ` Thomas Schmitt
2011-11-03 22:30 ` Thomas Schmitt
2011-11-04 9:18 ` Thomas Schmitt
2011-11-04 9:38 ` Paolo Bonzini
2011-11-04 11:09 ` Thomas Schmitt
2011-11-04 11:31 ` Paolo Bonzini
2011-11-04 13:03 ` Thomas Schmitt
2011-11-04 20:28 ` Thomas Schmitt
2011-11-05 8:33 ` Paolo Bonzini
2011-11-05 13:00 ` Thomas Schmitt
2011-11-05 14:37 ` Thomas Schmitt
2011-11-05 15:53 ` Paolo Bonzini
2011-11-05 16:38 ` Thomas Schmitt
2011-11-05 20:47 ` Thomas Schmitt
2011-11-06 8:17 ` Paolo Bonzini
2011-11-06 10:35 ` Thomas Schmitt
2011-11-06 20:14 ` Thomas Schmitt
2011-11-07 8:02 ` Paolo Bonzini
2011-11-07 10:04 ` Thomas Schmitt
2011-11-07 11:13 ` Paolo Bonzini
2011-11-07 11:24 ` Zhi Yong Wu
2011-11-07 11:29 ` Paolo Bonzini
2011-11-07 11:40 ` Zhi Yong Wu
2011-11-06 9:31 ` Thomas Schmitt
2011-11-04 13:26 ` Andreas Färber
2011-11-04 14:46 ` Thomas Schmitt
2011-11-07 8:48 ` Zhi Yong Wu
2011-11-02 15:15 ` Thomas Schmitt
2011-11-02 16:22 ` Paolo Bonzini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='j8s6uv$jik$1@dough.gmane.org' \
--to=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).