From: Paolo Bonzini <pbonzini@redhat.com>
To: qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH 4/4] Makefile: fix qga dependencies
Date: Thu, 17 Nov 2011 10:31:27 +0100 [thread overview]
Message-ID: <ja2k9f$jdo$2@dough.gmane.org> (raw)
In-Reply-To: <20111116215829.GA767@redhat.com>
On 11/16/2011 10:58 PM, Michael S. Tsirkin wrote:
> .c files include .h files, so .o depends on .h,
> and the linked result depends on .o.
> We got it wrong for qga rules, fix it up.
Another possible option is to make the "all" target depend on
GENERATED_HEADERS and GENERATED_SOURCES, like
all: $(GENERATED_HEADERS) $(GENERATED_SOURCES)
@$(MAKE) build-all
and drop the dependency everywhere else. This will check the dependency
at the beginning of the build (should be fine since the generated files
change rarely) and rely on automatic dependency generation for the
.o->.h dependencies.
Paolo
next prev parent reply other threads:[~2011-11-17 9:35 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-11-16 21:58 [Qemu-devel] [PATCH 4/4] Makefile: fix qga dependencies Michael S. Tsirkin
2011-11-17 9:31 ` Paolo Bonzini [this message]
2011-11-17 12:22 ` Andreas Färber
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='ja2k9f$jdo$2@dough.gmane.org' \
--to=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).