From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([140.186.70.92]:44547) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1RSZKF-0003LV-LO for qemu-devel@nongnu.org; Mon, 21 Nov 2011 14:14:46 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1RSZK7-00080f-Mh for qemu-devel@nongnu.org; Mon, 21 Nov 2011 14:14:43 -0500 Received: from lo.gmane.org ([80.91.229.12]:60358) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1RSZK7-0007xk-5o for qemu-devel@nongnu.org; Mon, 21 Nov 2011 14:14:35 -0500 Received: from list by lo.gmane.org with local (Exim 4.69) (envelope-from ) id 1RSZK5-00045g-EZ for qemu-devel@nongnu.org; Mon, 21 Nov 2011 20:14:33 +0100 Received: from 93-34-207-114.ip51.fastwebnet.it ([93.34.207.114]) by main.gmane.org with esmtp (Gmexim 0.1 (Debian)) id 1AlnuQ-0007hv-00 for ; Mon, 21 Nov 2011 20:14:33 +0100 Received: from pbonzini by 93-34-207-114.ip51.fastwebnet.it with local (Gmexim 0.1 (Debian)) id 1AlnuQ-0007hv-00 for ; Mon, 21 Nov 2011 20:14:33 +0100 From: Paolo Bonzini Date: Mon, 21 Nov 2011 20:14:20 +0100 Message-ID: References: <1321895345-27959-1-git-send-email-lcapitulino@redhat.com> <1321895345-27959-2-git-send-email-lcapitulino@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit In-Reply-To: <1321895345-27959-2-git-send-email-lcapitulino@redhat.com> Subject: Re: [Qemu-devel] [PATCH 1/4] configure: Don't mix glib and libcheck tests List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org On 11/21/2011 06:09 PM, Luiz Capitulino wrote: > test-coroutine is listed as a libcheck test in the 'checks' variable. This > is not right because 'make check' won't run test-coroutine if libcheck > tests are not enabled (either because libcheck isn't detected or because > --disable-check-utests is passed). > > Tests using the glib test framework are independent from libcheck and > afaik are always present (although having a configure switch to disable > them is probably worth it). > > Untagle test-coroutine from the libcheck tests by introducing the > 'test_progs' variable and using it to generate the test list used by > 'make check'. > > Signed-off-by: Luiz Capitulino This should be ok for 1.0 too. Paolo