From: Paolo Bonzini <pbonzini@redhat.com>
To: qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH 1/4] rtc: fix 12-hour mode
Date: Tue, 22 Nov 2011 08:30:06 +0100 [thread overview]
Message-ID: <jafj20$er9$1@dough.gmane.org> (raw)
In-Reply-To: <4ECB4399.3090603@linux.vnet.ibm.com>
On 11/22/2011 07:39 AM, Mark Wu wrote:
>> Hours in 12-hour mode are in the 1-12 range, not 0-11.
> Interesting. I would like to know how you could find this problem. It
> seems linux driver never changes the format and 24-hour is default in
> rtc emulation code. So how did it expose and how to test it?
It is exposed by reading the datasheet. :)
Honestly, to test it I just added two for loops, I didn't test it on a
real VM. But you could do all these tests using a DOS program for example.
Paolo
next prev parent reply other threads:[~2011-11-22 7:30 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-11-21 18:00 [Qemu-devel] [PATCH 0/4] Fixes to the rtc device model Paolo Bonzini
2011-11-21 18:00 ` [Qemu-devel] [PATCH 1/4] rtc: fix 12-hour mode Paolo Bonzini
2011-11-22 6:39 ` Mark Wu
2011-11-22 7:30 ` Paolo Bonzini [this message]
2012-01-01 14:53 ` Avi Kivity
2012-01-01 19:53 ` Paolo Bonzini
2011-11-21 18:00 ` [Qemu-devel] [PATCH 2/4] rtc: raise AF bit when the alarm is encountered but AIE=0 Paolo Bonzini
2011-11-21 18:00 ` [Qemu-devel] [PATCH 3/4] rtc: raise PF bit when the periodic timer triggers but PIE=0 Paolo Bonzini
2011-11-21 18:00 ` [Qemu-devel] [PATCH 4/4] rtc: clear non-PF bits when reinjecting on ack Paolo Bonzini
2011-12-30 15:58 ` [Qemu-devel] [PATCH 0/4] Fixes to the rtc device model Paolo Bonzini
2012-01-13 15:54 ` Paolo Bonzini
2012-01-13 16:54 ` Anthony Liguori
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='jafj20$er9$1@dough.gmane.org' \
--to=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).