From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([140.186.70.92]:51201)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <gceq-qemu-devel@m.gmane.org>) id 1RSkoD-0001Om-Rq
	for qemu-devel@nongnu.org; Tue, 22 Nov 2011 02:30:26 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <gceq-qemu-devel@m.gmane.org>) id 1RSkoC-0004WW-Ew
	for qemu-devel@nongnu.org; Tue, 22 Nov 2011 02:30:25 -0500
Received: from lo.gmane.org ([80.91.229.12]:37827)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <gceq-qemu-devel@m.gmane.org>) id 1RSkoC-0004WR-8g
	for qemu-devel@nongnu.org; Tue, 22 Nov 2011 02:30:24 -0500
Received: from list by lo.gmane.org with local (Exim 4.69)
	(envelope-from <gceq-qemu-devel@m.gmane.org>) id 1RSko8-0003yV-MZ
	for qemu-devel@nongnu.org; Tue, 22 Nov 2011 08:30:20 +0100
Received: from 93-34-207-114.ip51.fastwebnet.it ([93.34.207.114])
	by main.gmane.org with esmtp (Gmexim 0.1 (Debian))
	id 1AlnuQ-0007hv-00
	for <qemu-devel@nongnu.org>; Tue, 22 Nov 2011 08:30:20 +0100
Received: from pbonzini by 93-34-207-114.ip51.fastwebnet.it with local (Gmexim
	0.1 (Debian)) id 1AlnuQ-0007hv-00
	for <qemu-devel@nongnu.org>; Tue, 22 Nov 2011 08:30:20 +0100
From: Paolo Bonzini <pbonzini@redhat.com>
Date: Tue, 22 Nov 2011 08:30:06 +0100
Message-ID: <jafj20$er9$1@dough.gmane.org>
References: <1321898431-18449-1-git-send-email-pbonzini@redhat.com>
	<1321898431-18449-2-git-send-email-pbonzini@redhat.com>
	<4ECB4399.3090603@linux.vnet.ibm.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
In-Reply-To: <4ECB4399.3090603@linux.vnet.ibm.com>
Subject: Re: [Qemu-devel] [PATCH 1/4] rtc: fix 12-hour mode
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: qemu-devel@nongnu.org

On 11/22/2011 07:39 AM, Mark Wu wrote:
>> Hours in 12-hour mode are in the 1-12 range, not 0-11.
> Interesting. I would like to know how you could find this problem. It
> seems linux driver never changes the format  and 24-hour is default in
> rtc emulation code. So how did it expose and how to test it?

It is exposed by reading the datasheet. :)

Honestly, to test it I just added two for loops, I didn't test it on a 
real VM.  But you could do all these tests using a DOS program for example.

Paolo