From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([140.186.70.92]:59550)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <gceq-qemu-devel@m.gmane.org>) id 1RT7Bw-0001xs-LB
	for qemu-devel@nongnu.org; Wed, 23 Nov 2011 02:24:25 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <gceq-qemu-devel@m.gmane.org>) id 1RT7Bv-0000AJ-J2
	for qemu-devel@nongnu.org; Wed, 23 Nov 2011 02:24:24 -0500
Received: from lo.gmane.org ([80.91.229.12]:40559)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <gceq-qemu-devel@m.gmane.org>) id 1RT7Bv-0000A3-Dt
	for qemu-devel@nongnu.org; Wed, 23 Nov 2011 02:24:23 -0500
Received: from list by lo.gmane.org with local (Exim 4.69)
	(envelope-from <gceq-qemu-devel@m.gmane.org>) id 1RT7Bs-0007pr-Fk
	for qemu-devel@nongnu.org; Wed, 23 Nov 2011 08:24:20 +0100
Received: from 93-34-207-114.ip51.fastwebnet.it ([93.34.207.114])
	by main.gmane.org with esmtp (Gmexim 0.1 (Debian))
	id 1AlnuQ-0007hv-00
	for <qemu-devel@nongnu.org>; Wed, 23 Nov 2011 08:24:20 +0100
Received: from pbonzini by 93-34-207-114.ip51.fastwebnet.it with local (Gmexim
	0.1 (Debian)) id 1AlnuQ-0007hv-00
	for <qemu-devel@nongnu.org>; Wed, 23 Nov 2011 08:24:20 +0100
From: Paolo Bonzini <pbonzini@redhat.com>
Date: Wed, 23 Nov 2011 08:24:05 +0100
Message-ID: <jai72l$iao$1@dough.gmane.org>
References: <1321529765-14863-1-git-send-email-cyliu@suse.com>
	<4EC50F0F.3020400@redhat.com>
	<4EC64EC90200006600006BCD@novprvlin0050.provo.novell.com>
	<4EC61E60.2040405@redhat.com>
	<4ECD32BF0200006600006F28@novprvlin0050.provo.novell.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
In-Reply-To: <4ECD32BF0200006600006F28@novprvlin0050.provo.novell.com>
Subject: Re: [Qemu-devel] [PATCH V2] Add -f option to qemu-nbd
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: qemu-devel@nongnu.org

On 11/23/2011 07:51 AM, Chun Yan Liu wrote:
>
> According to above code logic, if lock in an early place is not
> accepted, then removing CLEAR_SOCK in nbd_init phase can also solve
> problem. In fact, if cleanup work done well, I think that ioctl is not
> needed. Any comments?

I think you're right.  In addition, SET_BLKSIZE and SET_SIZE should not 
be sent unless SET_SOCK succeeds.

Paolo