From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([140.186.70.92]:60749)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <gceq-qemu-devel@m.gmane.org>) id 1RTYOp-0002LK-Qn
	for qemu-devel@nongnu.org; Thu, 24 Nov 2011 07:27:32 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <gceq-qemu-devel@m.gmane.org>) id 1RTYOl-0001Eh-8D
	for qemu-devel@nongnu.org; Thu, 24 Nov 2011 07:27:31 -0500
Received: from lo.gmane.org ([80.91.229.12]:59616)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <gceq-qemu-devel@m.gmane.org>) id 1RTYOk-0001Ea-RD
	for qemu-devel@nongnu.org; Thu, 24 Nov 2011 07:27:27 -0500
Received: from list by lo.gmane.org with local (Exim 4.69)
	(envelope-from <gceq-qemu-devel@m.gmane.org>) id 1RTYOd-0005gd-Gf
	for qemu-devel@nongnu.org; Thu, 24 Nov 2011 13:27:19 +0100
Received: from 93-34-207-114.ip51.fastwebnet.it ([93.34.207.114])
	by main.gmane.org with esmtp (Gmexim 0.1 (Debian))
	id 1AlnuQ-0007hv-00
	for <qemu-devel@nongnu.org>; Thu, 24 Nov 2011 13:27:19 +0100
Received: from pbonzini by 93-34-207-114.ip51.fastwebnet.it with local (Gmexim
	0.1 (Debian)) id 1AlnuQ-0007hv-00
	for <qemu-devel@nongnu.org>; Thu, 24 Nov 2011 13:27:19 +0100
From: Paolo Bonzini <pbonzini@redhat.com>
Date: Thu, 24 Nov 2011 13:27:06 +0100
Message-ID: <jald6r$lj9$1@dough.gmane.org>
References: <1322136691-23057-1-git-send-email-jcmvbkbc@gmail.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
In-Reply-To: <1322136691-23057-1-git-send-email-jcmvbkbc@gmail.com>
Subject: Re: [Qemu-devel] [PATCH v4] configure: avoid screening of --{en,
 dis}able-usb-redir options
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: qemu-devel@nongnu.org

On 11/24/2011 01:11 PM, Max Filippov wrote:
> --*dir) option pattern precede --{en,dis}able-usb-redir) patterns in the
> option analysis switch, making the latter options have no effect.
>
> There were some --*dir that are supported by Autoconf and not by QEMU configure.
> The aim was to let QEMU packagers use the rpm (or similar) macro that overrides
> directories for their distribution.
>
> Replace --*dir with exact option names.
>
> Signed-off-by: Max Filippov<jcmvbkbc@gmail.com>
> ---
> v2 ->  v3 changes: add --htmldir
> v3 ->  v4 changes: collapse cases, include rationale into the configure
> ---
>   configure |   10 ++++++++--
>   1 files changed, 8 insertions(+), 2 deletions(-)
>
> diff --git a/configure b/configure
> index f033438..60c3740 100755
> --- a/configure
> +++ b/configure
> @@ -569,6 +569,14 @@ for opt do
>     ;;
>     --sysconfdir=*) sysconfdir="$optarg"
>     ;;
> +  --sbindir=*|--libexecdir=*|--sharedstatedir=*|--localstatedir=*|\
> +  --oldincludedir=*|--datarootdir=*|--infodir=*|--localedir=*|\
> +  --htmldir=*|--dvidir=*|--pdfdir=*|--psdir=*)
> +    # These switches are silently ignored, for compatibility with
> +    # autoconf-generated configure scripts. This allows QEMU's
> +    # configure to be used by RPM and similar macros that set
> +    # lots of directory switches by default.
> +  ;;
>     --disable-sdl) sdl="no"
>     ;;
>     --enable-sdl) sdl="yes"
> @@ -759,8 +767,6 @@ for opt do
>     ;;
>     --enable-opengl) opengl="yes"
>     ;;
> -  --*dir)
> -  ;;
>     --disable-rbd) rbd="no"
>     ;;
>     --enable-rbd) rbd="yes"

Reviewed-by: Paolo Bonzini <pbonzini@redhat.com>