From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([140.186.70.92]:57091) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Rl3zh-0000u7-4J for qemu-devel@nongnu.org; Wed, 11 Jan 2012 14:38:00 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Rl3zb-0004d5-9G for qemu-devel@nongnu.org; Wed, 11 Jan 2012 14:37:57 -0500 Received: from lo.gmane.org ([80.91.229.12]:59376) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Rl3pz-0002sR-Lw for qemu-devel@nongnu.org; Wed, 11 Jan 2012 14:27:55 -0500 Received: from list by lo.gmane.org with local (Exim 4.69) (envelope-from ) id 1Rl3py-0001IU-HC for qemu-devel@nongnu.org; Wed, 11 Jan 2012 20:27:54 +0100 Received: from 93-34-200-238.ip51.fastwebnet.it ([93.34.200.238]) by main.gmane.org with esmtp (Gmexim 0.1 (Debian)) id 1AlnuQ-0007hv-00 for ; Wed, 11 Jan 2012 20:27:54 +0100 Received: from pbonzini by 93-34-200-238.ip51.fastwebnet.it with local (Gmexim 0.1 (Debian)) id 1AlnuQ-0007hv-00 for ; Wed, 11 Jan 2012 20:27:54 +0100 From: Paolo Bonzini Date: Wed, 11 Jan 2012 20:27:42 +0100 Message-ID: References: <1326222656-26588-1-git-send-email-aliguori@us.ibm.com> <1326222656-26588-15-git-send-email-aliguori@us.ibm.com> <4F0DC1A6.7000605@codemonkey.ws> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit In-Reply-To: <4F0DC1A6.7000605@codemonkey.ws> Subject: Re: [Qemu-devel] [PATCH 15/15] qtest: add rtc-test test-case List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org On 01/11/2012 06:06 PM, Anthony Liguori wrote: > >> The right thing to do would be to run the test with >> vm_clock for the rtc_clock, add a way for the qtest machine to bump >> the vm_clock >> to the next event, > > I actually was looking at this yesterday. Just bumping to the next > event is not enough, you want to be able to control how time > progresses. I was thinking of adding another qtest_clock and allowing > the rtc to use the qtest_clock. Yes, that's right. Only remark, I think it makes sense to reuse the vm_clock, so that you can reuse the icount infrastructure in -icount 0. qemu_icount is then simply your nanosecond count. This requires you not to set env->halted, though. Paolo