From: Andreas Schwab <schwab@suse.de>
To: qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH] Allow setting the vendor_id string with x86's -cpu option
Date: Sun, 09 Dec 2007 19:29:49 +0100 [thread overview]
Message-ID: <jesl2blo0y.fsf@sykes.suse.de> (raw)
In-Reply-To: <20071209135201.GA5113@karma.qumranet.com> (Dan Kenigsberg's message of "Sun\, 9 Dec 2007 15\:52\:01 +0200")
Dan Kenigsberg <danken@qumranet.com> writes:
> + x86_cpu_def->vendor1 = val[0] + (val[1] << 8)
> + + (val[2] << 16) + (val[3] << 24);
> + x86_cpu_def->vendor2 = val[4] + (val[5] << 8)
> + + (val[6] << 16) + (val[7] << 24);
> + x86_cpu_def->vendor3 = val[8] + (val[9] << 8)
> + + (val[10] << 16) + (val[11] << 24);
That will do the wrong thing with the sign bit.
Andreas.
--
Andreas Schwab, SuSE Labs, schwab@suse.de
SuSE Linux Products GmbH, Maxfeldstraße 5, 90409 Nürnberg, Germany
PGP key fingerprint = 58CA 54C7 6D53 942B 1756 01D3 44D5 214B 8276 4ED5
"And now for something completely different."
next prev parent reply other threads:[~2007-12-09 18:29 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-11-25 13:23 [Qemu-devel] [PATCH] Allow setting the vendor_id string with x86's -cpu option Dan Kenigsberg
2007-12-09 3:02 ` Thiemo Seufer
2007-12-09 9:27 ` Dan Kenigsberg
2007-12-09 11:36 ` Paul Brook
2007-12-09 13:52 ` Dan Kenigsberg
2007-12-09 18:29 ` Andreas Schwab [this message]
2007-12-09 18:58 ` Dan Kenigsberg
2007-12-09 20:00 ` Dan Kenigsberg
2007-12-20 16:40 ` [Qemu-devel] [PATCH] Allow setting the vendor and model_id strings " Dan Kenigsberg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=jesl2blo0y.fsf@sykes.suse.de \
--to=schwab@suse.de \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).