From: Paolo Bonzini <pbonzini@redhat.com>
To: qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH 5/6] PPC: booke206: Check for min/max TLB entry size
Date: Fri, 20 Jan 2012 09:09:37 +0100 [thread overview]
Message-ID: <jfb7g1$la1$1@dough.gmane.org> (raw)
In-Reply-To: <1327029449-13220-6-git-send-email-agraf@suse.de>
On 01/20/2012 04:17 AM, Alexander Graf wrote:
> + if ((size_tlb > size_max) || (size_tlb < size_max)) {
You want < size_min, and the extra parentheses look odd.
> + /* set to min size */
> + tlb->mas1&= ~MAS1_TSIZE_MASK;
> + tlb->mas1 |= size_min<< (MAS1_TSIZE_SHIFT + 1);
> + }
next prev parent reply other threads:[~2012-01-20 8:10 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-01-20 3:17 [Qemu-devel] [PATCH 0/6] Make -cpu e500mc useful in TCG Alexander Graf
2012-01-20 3:17 ` [Qemu-devel] [PATCH 1/6] PPC: Add IVOR 38-42 Alexander Graf
2012-01-20 7:54 ` Andreas Färber
2012-01-20 3:17 ` [Qemu-devel] [PATCH 2/6] PPC: e500mc: add missing IVORs to bitmap Alexander Graf
2012-01-20 19:16 ` Scott Wood
2012-01-21 4:05 ` Alexander Graf
2012-01-20 3:17 ` [Qemu-devel] [PATCH 3/6] PPC: e500: msync is 440 only, e500 has real sync Alexander Graf
2012-01-20 19:39 ` Scott Wood
2012-01-20 3:17 ` [Qemu-devel] [PATCH 4/6] PPC: booke206: allow NULL raddr in ppcmas_tlb_check Alexander Graf
2012-01-20 3:17 ` [Qemu-devel] [PATCH 5/6] PPC: booke206: Check for min/max TLB entry size Alexander Graf
2012-01-20 8:09 ` Paolo Bonzini [this message]
2012-01-20 8:09 ` Andreas Färber
2012-01-20 13:21 ` [Qemu-devel] [PATCH] " Alexander Graf
2012-01-20 20:01 ` Scott Wood
2012-01-21 2:43 ` Alexander Graf
2012-01-23 17:28 ` Scott Wood
2012-01-23 17:30 ` Alexander Graf
2012-01-20 3:17 ` [Qemu-devel] [PATCH 6/6] PPC: booke206: Implement tlbilx Alexander Graf
2012-01-20 20:40 ` Scott Wood
2012-01-21 2:57 ` Alexander Graf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='jfb7g1$la1$1@dough.gmane.org' \
--to=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).