From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([140.186.70.92]:39421)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <gceq-qemu-devel@m.gmane.org>) id 1Ro9Xp-00065O-6T
	for qemu-devel@nongnu.org; Fri, 20 Jan 2012 03:10:02 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <gceq-qemu-devel@m.gmane.org>) id 1Ro9Xj-0001Xs-Mx
	for qemu-devel@nongnu.org; Fri, 20 Jan 2012 03:09:57 -0500
Received: from lo.gmane.org ([80.91.229.12]:58757)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <gceq-qemu-devel@m.gmane.org>) id 1Ro9Xj-0001Xf-Hx
	for qemu-devel@nongnu.org; Fri, 20 Jan 2012 03:09:51 -0500
Received: from list by lo.gmane.org with local (Exim 4.69)
	(envelope-from <gceq-qemu-devel@m.gmane.org>) id 1Ro9Xh-0002cX-JC
	for qemu-devel@nongnu.org; Fri, 20 Jan 2012 09:09:49 +0100
Received: from 93-34-200-238.ip51.fastwebnet.it ([93.34.200.238])
	by main.gmane.org with esmtp (Gmexim 0.1 (Debian))
	id 1AlnuQ-0007hv-00
	for <qemu-devel@nongnu.org>; Fri, 20 Jan 2012 09:09:49 +0100
Received: from pbonzini by 93-34-200-238.ip51.fastwebnet.it with local (Gmexim
	0.1 (Debian)) id 1AlnuQ-0007hv-00
	for <qemu-devel@nongnu.org>; Fri, 20 Jan 2012 09:09:49 +0100
From: Paolo Bonzini <pbonzini@redhat.com>
Date: Fri, 20 Jan 2012 09:09:37 +0100
Message-ID: <jfb7g1$la1$1@dough.gmane.org>
References: <1327029449-13220-1-git-send-email-agraf@suse.de>
	<1327029449-13220-6-git-send-email-agraf@suse.de>
Mime-Version: 1.0
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
In-Reply-To: <1327029449-13220-6-git-send-email-agraf@suse.de>
Subject: Re: [Qemu-devel] [PATCH 5/6] PPC: booke206: Check for min/max TLB
	entry size
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: qemu-devel@nongnu.org

On 01/20/2012 04:17 AM, Alexander Graf wrote:
> +    if ((size_tlb > size_max) || (size_tlb < size_max)) {

You want < size_min, and the extra parentheses look odd.

> +        /* set to min size */
> +        tlb->mas1&= ~MAS1_TSIZE_MASK;
> +        tlb->mas1 |= size_min<<  (MAS1_TSIZE_SHIFT + 1);
> +    }