From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([140.186.70.92]:49270) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1RqJzY-0006CT-Ta for qemu-devel@nongnu.org; Thu, 26 Jan 2012 02:43:36 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1RqJzX-0003mQ-Mi for qemu-devel@nongnu.org; Thu, 26 Jan 2012 02:43:32 -0500 Received: from lo.gmane.org ([80.91.229.12]:40737) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1RqJzX-0003mM-8N for qemu-devel@nongnu.org; Thu, 26 Jan 2012 02:43:31 -0500 Received: from list by lo.gmane.org with local (Exim 4.69) (envelope-from ) id 1RqJzW-0000Sh-MO for qemu-devel@nongnu.org; Thu, 26 Jan 2012 08:43:30 +0100 Received: from 93-34-182-16.ip50.fastwebnet.it ([93.34.182.16]) by main.gmane.org with esmtp (Gmexim 0.1 (Debian)) id 1AlnuQ-0007hv-00 for ; Thu, 26 Jan 2012 08:43:30 +0100 Received: from pbonzini by 93-34-182-16.ip50.fastwebnet.it with local (Gmexim 0.1 (Debian)) id 1AlnuQ-0007hv-00 for ; Thu, 26 Jan 2012 08:43:30 +0100 From: Paolo Bonzini Date: Thu, 26 Jan 2012 08:43:18 +0100 Message-ID: References: <1327433600-7403-1-git-send-email-aliguori@us.ibm.com> <1327433600-7403-5-git-send-email-aliguori@us.ibm.com> <4F20746F.1000905@suse.de> <4F207634.4050700@codemonkey.ws> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-15; format=flowed Content-Transfer-Encoding: 8bit In-Reply-To: <4F207634.4050700@codemonkey.ws> Subject: Re: [Qemu-devel] [PATCH 04/28] qom: add the base Object class (v2) List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org On 01/25/2012 10:37 PM, Anthony Liguori wrote: > On 01/25/2012 03:30 PM, Andreas Färber wrote: >> Am 24.01.2012 20:32, schrieb Anthony Liguori: >>> This class provides the main building block for QEMU Object Model and is >>> extensively documented in the header file. It is largely inspired by >>> GObject. >>> >>> Signed-off-by: Anthony Liguori >>> --- >>> v1 -> v2 >>> - remove printf() in type registration >>> - fix typo in comment (Paolo) >>> - make Interface private >>> - move object into a new directory and move header into include/qemu/ >> >> Some of us had expressed concerns over introducing include/. Any >> particular reason you're doing it still? > > Because it's a great idea and I thought everyone loved it? > > Can you point me to the concerns raised, I'll go back and look. I didn't > think it was contentious... > > To summarize my rationale for it: > > 1) It avoids all of the non-sense with conflicting system headers > (because we -Iinclude and the headers live in include/qemu) > > 2) It establishes what are public functions for use in other parts of > qemu vs. private headers (which we currently use based on ad-hoc naming > schemes like block_int.h). > > 3) I think the kernel serves as an existence proof that this method to > manage headers works really well in practice. 4) Because it's easy enough to complete the transition with a few "git mv", so there's hope not to be stuck with 2 headers in include/ for 5 years. Paolo