From: Paolo Bonzini <pbonzini@redhat.com>
To: qemu-devel@nongnu.org
Cc: xen-devel@lists.xensource.com
Subject: Re: [Qemu-devel] [PATCH v2 2/5] xen: disable rtc_clock
Date: Fri, 27 Jan 2012 15:41:29 +0100 [thread overview]
Message-ID: <jfud2p$h6$1@dough.gmane.org> (raw)
In-Reply-To: <1327667215-5411-2-git-send-email-stefano.stabellini@eu.citrix.com>
On 01/27/2012 01:26 PM, Stefano Stabellini wrote:
> rtc_clock is only used by the RTC emulator (mc146818rtc.c), however Xen
> has its own RTC emulator in the hypervisor so we can disable it.
>
> Signed-off-by: Stefano Stabellini<stefano.stabellini@eu.citrix.com>
> ---
> xen-all.c | 1 +
> 1 files changed, 1 insertions(+), 0 deletions(-)
>
> diff --git a/xen-all.c b/xen-all.c
> index d1fc597..bf183f7 100644
> --- a/xen-all.c
> +++ b/xen-all.c
> @@ -513,6 +513,7 @@ void xen_vcpu_init(void)
> qemu_register_reset(xen_reset_vcpu, first_cpu);
> xen_reset_vcpu(first_cpu);
> }
> + qemu_clock_enable(rtc_clock, false);
> }
>
> /* get the ioreq packets from share mem */
Depending on "-rtc clock=vm" or "-rtc clock=rt", this may not be true.
Why do you need to instantiate an RTC at all?
Paolo
next prev parent reply other threads:[~2012-01-27 14:41 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-01-27 12:26 [Qemu-devel] [PATCH v2 0/5] prevent Qemu from waking up needlessly Stefano Stabellini
2012-01-27 12:26 ` [Qemu-devel] [PATCH v2 1/5] xen: do not initialize the interval timer emulator Stefano Stabellini
2012-01-27 12:26 ` [Qemu-devel] [PATCH v2 2/5] xen: disable rtc_clock Stefano Stabellini
2012-01-27 14:41 ` Paolo Bonzini [this message]
2012-01-30 11:56 ` Stefano Stabellini
2012-01-30 11:59 ` Paolo Bonzini
2012-01-30 18:53 ` Stefano Stabellini
2012-01-30 19:28 ` Anthony Liguori
2012-01-31 7:30 ` Paolo Bonzini
2012-01-27 12:26 ` [Qemu-devel] [PATCH v2 3/5] xen: introduce an event channel for buffered io event notifications Stefano Stabellini
2012-01-27 12:26 ` [Qemu-devel] [PATCH v2 4/5] qemu_next_alarm_deadline: check the expire time of a clock only if it is enabled Stefano Stabellini
2012-01-27 14:42 ` Paolo Bonzini
2012-01-27 15:43 ` Stefano Stabellini
2012-01-27 15:53 ` Stefano Stabellini
2012-01-27 12:26 ` [Qemu-devel] [PATCH v2 5/5] qemu_calculate_timeout: increase minimum timeout to 1h Stefano Stabellini
2012-01-27 14:43 ` Paolo Bonzini
2012-01-27 15:44 ` Stefano Stabellini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='jfud2p$h6$1@dough.gmane.org' \
--to=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=xen-devel@lists.xensource.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).