[Qemu-devel] [PATCH v2] Fix dependency issue introduced by commit 7b93fadf3a38d1ed65ea5536a52efc2772c6e3b8

[Qemu-devel] [PATCH v2] Fix dependency issue introduced by commit 7b93fadf3a38d1ed65ea5536a52efc2772c6e3b8

[陳韋任]

  Commit 7b93fadf3a38d1ed65ea5536a52efc2772c6e3b8 adds basic version of bridge
helper, but introduces dependency issue at the same time. While building target
xxx-linux-user, qemu-bridge-helper.c needs config-host.h which is not generated
at the moment. Explicitly declaring the dependency for the helper in the
Makefile.

Signed-off-by: Chen Wei-Ren <chenwj@iis.sinica.edu.tw>
---
v2: Explicitly declaring the dependency for the helper instead of relying on
    ordering side-effects.

 Makefile |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/Makefile b/Makefile
index e66e885..1b2488c 100644
--- a/Makefile
+++ b/Makefile
@@ -36,7 +36,7 @@ $(call set-vpath, $(SRC_PATH):$(SRC_PATH)/hw)
 
 LIBS+=-lz $(LIBS_TOOLS)
 
-HELPERS-$(CONFIG_LINUX) = qemu-bridge-helper$(EXESUF)
+HELPERS-$(CONFIG_LINUX) : config-host.h qemu-bridge-helper$(EXESUF)
 
 ifdef BUILD_DOCS
 DOCS=qemu-doc.html qemu-tech.html qemu.1 qemu-img.1 qemu-nbd.8 QMP/qmp-commands.txt
-- 
1.7.3.4

Re: [Qemu-devel] [PATCH v2] Fix dependency issue introduced by commit 7b93fadf3a38d1ed65ea5536a52efc2772c6e3b8

[Paolo Bonzini]

On 02/22/2012 03:07 AM, 陳韋任 wrote:
>  
> -HELPERS-$(CONFIG_LINUX) = qemu-bridge-helper$(EXESUF)
> +HELPERS-$(CONFIG_LINUX) : config-host.h qemu-bridge-helper$(EXESUF)

This is not declaring the dependency, it is declaring a target.

The rule should be like

qemu-bridge-helper.o: config-host.h

Paolo

Re: [Qemu-devel] [PATCH v2] Fix dependency issue introduced by commit 7b93fadf3a38d1ed65ea5536a52efc2772c6e3b8

[Andreas Färber]

Am 22.02.2012 08:27, schrieb Paolo Bonzini:
> On 02/22/2012 03:07 AM, 陳韋任 wrote:
>>  
>> -HELPERS-$(CONFIG_LINUX) = qemu-bridge-helper$(EXESUF)
>> +HELPERS-$(CONFIG_LINUX) : config-host.h qemu-bridge-helper$(EXESUF)
> 
> This is not declaring the dependency, it is declaring a target.
> 
> The rule should be like
> 
> qemu-bridge-helper.o: config-host.h

...which Peter has already done:

http://patchwork.ozlabs.org/patch/142306/

Please coordinate with him.

Andreas

-- 
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany
GF: Jeff Hawn, Jennifer Guild, Felix Imendörffer; HRB 16746 AG Nürnberg

Re: [Qemu-devel] [PATCH v2] Fix dependency issue introduced by commit 7b93fadf3a38d1ed65ea5536a52efc2772c6e3b8

[陳韋任]

Hi Stefan,

  Peter already fix this issue [1]. Please ignore my patch, thanks!

Regards,
chenwj

[1] http://patchwork.ozlabs.org/patch/142306/

-- 
Wei-Ren Chen (陳韋任)
Computer Systems Lab, Institute of Information Science,
Academia Sinica, Taiwan (R.O.C.)
Tel:886-2-2788-3799 #1667
Homepage: http://people.cs.nctu.edu.tw/~chenwj

Re: [Qemu-devel] [PATCH v2] Fix dependency issue introduced by commit 7b93fadf3a38d1ed65ea5536a52efc2772c6e3b8

[陳韋任]

> ...which Peter has already done:
> 
> http://patchwork.ozlabs.org/patch/142306/
> 
> Please coordinate with him.

  O.K., I already told Stefan to ignore my patch. :)
Thanks!

Regards,
chenwj

-- 
Wei-Ren Chen (陳韋任)
Computer Systems Lab, Institute of Information Science,
Academia Sinica, Taiwan (R.O.C.)
Tel:886-2-2788-3799 #1667
Homepage: http://people.cs.nctu.edu.tw/~chenwj