From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([208.118.235.92]:39098)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <gceq-qemu-devel@m.gmane.org>) id 1S2lrk-0006jF-Kv
	for qemu-devel@nongnu.org; Wed, 29 Feb 2012 10:55:02 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <gceq-qemu-devel@m.gmane.org>) id 1S2lrd-0003ie-CW
	for qemu-devel@nongnu.org; Wed, 29 Feb 2012 10:54:56 -0500
Received: from plane.gmane.org ([80.91.229.3]:33214)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <gceq-qemu-devel@m.gmane.org>) id 1S2lrd-0003i7-6v
	for qemu-devel@nongnu.org; Wed, 29 Feb 2012 10:54:49 -0500
Received: from list by plane.gmane.org with local (Exim 4.69)
	(envelope-from <gceq-qemu-devel@m.gmane.org>) id 1S2lrX-0003F0-11
	for qemu-devel@nongnu.org; Wed, 29 Feb 2012 16:54:43 +0100
Received: from 93-34-182-16.ip50.fastwebnet.it ([93.34.182.16])
	by main.gmane.org with esmtp (Gmexim 0.1 (Debian))
	id 1AlnuQ-0007hv-00
	for <qemu-devel@nongnu.org>; Wed, 29 Feb 2012 16:54:42 +0100
Received: from pbonzini by 93-34-182-16.ip50.fastwebnet.it with local (Gmexim
	0.1 (Debian)) id 1AlnuQ-0007hv-00
	for <qemu-devel@nongnu.org>; Wed, 29 Feb 2012 16:54:42 +0100
From: Paolo Bonzini <pbonzini@redhat.com>
Date: Wed, 29 Feb 2012 16:54:30 +0100
Message-ID: <jilhnm$cv8$1@dough.gmane.org>
References: <1330473276-8975-1-git-send-email-mjt@tls.msk.ru>
	<1330473276-8975-3-git-send-email-mjt@msgid.tls.msk.ru>
Mime-Version: 1.0
Content-Type: text/plain; charset=ISO-8859-15
Content-Transfer-Encoding: 7bit
In-Reply-To: <1330473276-8975-3-git-send-email-mjt@msgid.tls.msk.ru>
Subject: Re: [Qemu-devel] [PATCH 2/3] Combine bdrv_aio_readv and
	bdrv_aio_writev into bdrv_aio_rw_vector
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: qemu-devel@nongnu.org

Il 29/02/2012 00:54, Michael Tokarev ha scritto:
> iscsi block driver may receive some additional work.  For now, some
> common code has been moved out of iscsi_aio_writev() and iscsi_aio_readv()
> into iscsi_aio_rw_vector().  Leftovers there can be optimized further,
> and consolidated into the rw_vector too.  Read and write callbacks are
> consolidated as well, and once the XXX "todo" bounce-buffer change is
> complete the only difference there should go away too.

What about flush, discard, etc.?

It seems to me that either we make a single entry point that takes some
kind of BlockRequest, or there is no reason to do partial unification.

Paolo