From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([208.118.235.92]:50028)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <gceq-qemu-devel@m.gmane.org>) id 1S8o93-0008A2-7Z
	for qemu-devel@nongnu.org; Sat, 17 Mar 2012 03:33:46 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <gceq-qemu-devel@m.gmane.org>) id 1S8o91-0004tU-L2
	for qemu-devel@nongnu.org; Sat, 17 Mar 2012 03:33:44 -0400
Received: from plane.gmane.org ([80.91.229.3]:42264)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <gceq-qemu-devel@m.gmane.org>) id 1S8o91-0004s7-Dr
	for qemu-devel@nongnu.org; Sat, 17 Mar 2012 03:33:43 -0400
Received: from list by plane.gmane.org with local (Exim 4.69)
	(envelope-from <gceq-qemu-devel@m.gmane.org>) id 1S8o8w-0001vE-PT
	for qemu-devel@nongnu.org; Sat, 17 Mar 2012 08:33:38 +0100
Received: from 93-34-182-16.ip50.fastwebnet.it ([93.34.182.16])
	by main.gmane.org with esmtp (Gmexim 0.1 (Debian))
	id 1AlnuQ-0007hv-00
	for <qemu-devel@nongnu.org>; Sat, 17 Mar 2012 08:33:38 +0100
Received: from pbonzini by 93-34-182-16.ip50.fastwebnet.it with local (Gmexim
	0.1 (Debian)) id 1AlnuQ-0007hv-00
	for <qemu-devel@nongnu.org>; Sat, 17 Mar 2012 08:33:38 +0100
From: Paolo Bonzini <pbonzini@redhat.com>
Date: Sat, 17 Mar 2012 08:33:29 +0100
Message-ID: <jk1eo9$eq$1@dough.gmane.org>
References: <20120317031124.88CE640139@buildbot.b1-systems.de>
	<4F643902.7080705@weilnetz.de>
Mime-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
In-Reply-To: <4F643902.7080705@weilnetz.de>
Subject: Re: [Qemu-devel] VDI patches
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: qemu-devel@nongnu.org

Il 17/03/2012 08:10, Stefan Weil ha scritto:
> Hi Kevin, hi Paolo,
> 
> the build failure is caused by the vdi changes: some versions of gcc
> detect uninitialized local variables (my gcc 4.4.5 does not).
> 
> I don't think that it's really an error because the code is guarded
> by the local variable 'block', but not all compilers are clever enough,
> so it should be fixed.
> 
> It can be fixed by modifying commit
> af93911fd45f4de34ca2d5813905e2cf43675c98
> (vdi: move aiocb fields to locals) like that:
> 
> --- a/block/vdi.c
> +++ b/block/vdi.c
> @@ -519,8 +519,8 @@ static int vdi_co_write(BlockDriverState *bs,
>      uint32_t block_index;
>      uint32_t sector_in_block;
>      uint32_t n_sectors;
> -    uint32_t bmap_first;
> -    uint32_t bmap_last;
> +    uint32_t bmap_first = VDI_UNALLOCATED;
> +    uint32_t bmap_last = VDI_UNALLOCATED;
>      uint8_t *block = NULL;
>      int ret = 0;
> 
> Regards,
> Stefan W.
> 
> 
> 

Yes, I'll post v2.

Paolo