From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:57926) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SAEcl-0002fn-Fb for qemu-devel@nongnu.org; Wed, 21 Mar 2012 02:02:20 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1SAEcj-0006WZ-Np for qemu-devel@nongnu.org; Wed, 21 Mar 2012 02:02:19 -0400 Received: from plane.gmane.org ([80.91.229.3]:56533) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SAEcj-0006V3-Gv for qemu-devel@nongnu.org; Wed, 21 Mar 2012 02:02:17 -0400 Received: from list by plane.gmane.org with local (Exim 4.69) (envelope-from ) id 1SAEch-0003GJ-3P for qemu-devel@nongnu.org; Wed, 21 Mar 2012 07:02:15 +0100 Received: from 93-34-182-16.ip50.fastwebnet.it ([93.34.182.16]) by main.gmane.org with esmtp (Gmexim 0.1 (Debian)) id 1AlnuQ-0007hv-00 for ; Wed, 21 Mar 2012 07:02:15 +0100 Received: from pbonzini by 93-34-182-16.ip50.fastwebnet.it with local (Gmexim 0.1 (Debian)) id 1AlnuQ-0007hv-00 for ; Wed, 21 Mar 2012 07:02:15 +0100 From: Paolo Bonzini Date: Wed, 21 Mar 2012 07:02:05 +0100 Message-ID: References: <1332277190-14477-1-git-send-email-vianac@linux.vnet.ibm.com> <1332277190-14477-2-git-send-email-vianac@linux.vnet.ibm.com> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit In-Reply-To: <1332277190-14477-2-git-send-email-vianac@linux.vnet.ibm.com> Subject: Re: [Qemu-devel] [PATCH v2 2/2] Change timedrift default value to slew List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Il 20/03/2012 21:59, Crístian Viana ha scritto: > Windows 2008+ is very sensitive to missed ticks. The RTC is used by default as > the time source. If time drift is not enabled, Windows is prone to > blue screening. > > Signed-off-by: Crístian Viana > --- > hw/mc146818rtc.c | 2 +- > vl.c | 2 +- > 2 files changed, 2 insertions(+), 2 deletions(-) > > diff --git a/hw/mc146818rtc.c b/hw/mc146818rtc.c > index 2b59c36..2b31587 100644 > --- a/hw/mc146818rtc.c > +++ b/hw/mc146818rtc.c > @@ -726,7 +726,7 @@ ISADevice *rtc_init(ISABus *bus, int base_year, qemu_irq intercept_irq) > static Property mc146818rtc_properties[] = { > DEFINE_PROP_INT32("base_year", RTCState, base_year, 1980), > DEFINE_PROP_LOSTTICKPOLICY("lost_tick_policy", RTCState, > - lost_tick_policy, LOST_TICK_DISCARD), > + lost_tick_policy, LOST_TICK_SLEW), > DEFINE_PROP_END_OF_LIST(), > }; > > diff --git a/vl.c b/vl.c > index 112b0e0..62dda67 100644 > --- a/vl.c > +++ b/vl.c > @@ -550,7 +550,7 @@ static void configure_rtc(QemuOpts *opts) > > qdev_prop_register_global_list(slew_lost_ticks); > } else if (!strcmp(value, "none")) { > - /* discard is default */ > + /* do nothing */ > } else { > fprintf(stderr, "qemu: invalid option value '%s'\n", value); > exit(1); This piece of code from the previous if: if (!strcmp(value, "slew")) { static GlobalProperty slew_lost_ticks[] = { { .driver = "mc146818rtc", .property = "lost_tick_policy", .value = "slew", }, { /* end of list */ } }; qdev_prop_register_global_list(slew_lost_ticks); needs to be adjusted and moved to the "if (!strmp(value, "none"))" branch. Patch 1 looks good. Paolo