From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([208.118.235.92]:47900)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <gceq-qemu-devel@m.gmane.org>) id 1SEoOo-0004pe-EY
	for qemu-devel@nongnu.org; Mon, 02 Apr 2012 17:02:51 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <gceq-qemu-devel@m.gmane.org>) id 1SEoOm-0000hD-Ej
	for qemu-devel@nongnu.org; Mon, 02 Apr 2012 17:02:50 -0400
Received: from plane.gmane.org ([80.91.229.3]:55466)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <gceq-qemu-devel@m.gmane.org>) id 1SEoOm-0000h0-7W
	for qemu-devel@nongnu.org; Mon, 02 Apr 2012 17:02:48 -0400
Received: from list by plane.gmane.org with local (Exim 4.69)
	(envelope-from <gceq-qemu-devel@m.gmane.org>) id 1SEoOi-0004nZ-Fx
	for qemu-devel@nongnu.org; Mon, 02 Apr 2012 23:02:44 +0200
Received: from 93-34-182-16.ip50.fastwebnet.it ([93.34.182.16])
	by main.gmane.org with esmtp (Gmexim 0.1 (Debian))
	id 1AlnuQ-0007hv-00
	for <qemu-devel@nongnu.org>; Mon, 02 Apr 2012 23:02:44 +0200
Received: from pbonzini by 93-34-182-16.ip50.fastwebnet.it with local (Gmexim
	0.1 (Debian)) id 1AlnuQ-0007hv-00
	for <qemu-devel@nongnu.org>; Mon, 02 Apr 2012 23:02:44 +0200
From: Paolo Bonzini <pbonzini@redhat.com>
Date: Mon, 02 Apr 2012 23:02:27 +0200
Message-ID: <jld454$id2$1@dough.gmane.org>
References: <1333376921-13834-1-git-send-email-i.mitsyanko@samsung.com>
	<1333376921-13834-7-git-send-email-i.mitsyanko@samsung.com>
	<CAFEAcA_V1HfQOyh+3dvEEXKzE0+k5USNm5w8u7zY+A1kYxtZig@mail.gmail.com>
	<4F7A1298.70507@samsung.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
In-Reply-To: <4F7A1298.70507@samsung.com>
Subject: Re: [Qemu-devel] [PATCH 6/6] hw/sd.c: convert to QOM object
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: qemu-devel@nongnu.org

Il 02/04/2012 22:56, Igor Mitsyanko ha scritto:
> 2) At first I made SD card child of SD host controller, but it most
> certainly wrong, it should be a link.

This is a bit thorny, because BlockDriverState exposes a slot and its
medium, not just the medium (you can have an empty BDS, and that is not
NULL).

I think the right place for the SD card would be a child of the block
device, but as block devices are not qdevified, for now it can be left
as a child of the host controller.

The patch looks good, except that I would prefer to have wrappers for
SD_GET_CLASS(foo)->method(args) in sd.h.  It would also make the patch
much smaller.

Paolo