From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:59105)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <bsd@redhat.com>) id 1ZzoV1-0008SI-6o
	for qemu-devel@nongnu.org; Fri, 20 Nov 2015 11:25:24 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <bsd@redhat.com>) id 1ZzoUx-0000SL-7Q
	for qemu-devel@nongnu.org; Fri, 20 Nov 2015 11:25:23 -0500
Received: from mx1.redhat.com ([209.132.183.28]:36124)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <bsd@redhat.com>) id 1ZzoUx-0000S3-2J
	for qemu-devel@nongnu.org; Fri, 20 Nov 2015 11:25:19 -0500
From: Bandan Das <bsd@redhat.com>
References: <1447939696-28930-1-git-send-email-mst@redhat.com>
	<1447939696-28930-9-git-send-email-mst@redhat.com>
	<jpgoaep209g.fsf@linux.bootlegged.copy>
	<20151119224209-mutt-send-email-mst@redhat.com>
	<87r3jlso09.fsf@blackfin.pond.sub.org>
	<20151120114320-mutt-send-email-mst@redhat.com>
Date: Fri, 20 Nov 2015 11:25:17 -0500
In-Reply-To: <20151120114320-mutt-send-email-mst@redhat.com> (Michael
	S. Tsirkin's message of "Fri, 20 Nov 2015 11:43:59 +0200")
Message-ID: <jpg610w4p02.fsf@linux.bootlegged.copy>
MIME-Version: 1.0
Content-Type: text/plain
Subject: Re: [Qemu-devel] [PULL 08/15] i440fx: print an error message if
	user tries to enable iommu
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: "Michael S. Tsirkin" <mst@redhat.com>
Cc: Peter Maydell <peter.maydell@linaro.org>, Markus Armbruster <armbru@redhat.com>, qemu-devel@nongnu.org

"Michael S. Tsirkin" <mst@redhat.com> writes:

> On Thu, Nov 19, 2015 at 10:00:38PM +0100, Markus Armbruster wrote:
>> "Michael S. Tsirkin" <mst@redhat.com> writes:
>> 
>> > On Thu, Nov 19, 2015 at 03:38:03PM -0500, Bandan Das wrote:
>> >> "Michael S. Tsirkin" <mst@redhat.com> writes:
>> >> 
>> >> > From: Bandan Das <bsd@redhat.com>
>> >> >
>> >> > There's no indication of any sort that i440fx doesn't support
>> >> > "iommu=on"
>> >> 
>> >> Oh, Markus quite didn't like this approach because this is
>> >> true for all other machines too. Anyway, I will keep in
>> >> mind to take care of this when I post a generic patch. 
>> >
>> > Do you think I should revert this one then?
>> 
>> The patch isn't wrong, it merely addresses only one special case of a
>> generic issue.  Probably the most important case in practice.  If I
>> understood Bandan correctly, he intended to drop this patch and work on
>> a general solution.  As far as I'm concerned, you can keep this patch if
>> dropping it is inconvenient.
>
> Bandan, I suggest you include the revert in your patchset
> when it's ready then. Maybe post 2.5.

Yes, will do. Thanks.