From: Bandan Das <bsd@redhat.com>
To: qemu-devel <qemu-devel@nongnu.org>,
Alex Williamson <alex.williamson@redhat.com>
Subject: [Qemu-devel] [PATCH] vfio: add check for memory region overflow condition
Date: Mon, 21 Mar 2016 18:00:50 -0400 [thread overview]
Message-ID: <jpg8u1blcdp.fsf@linux.bootlegged.copy> (raw)
vfio_listener_region_add for a iommu mr results in
an overflow assert since emulated iommu memory region is initialized
with UINT64_MAX. Add a check just like memory_region_size()
does.
Signed-off-by: Bandan Das <bsd@redhat.com>
---
hw/vfio/common.c | 7 ++++++-
1 file changed, 6 insertions(+), 1 deletion(-)
diff --git a/hw/vfio/common.c b/hw/vfio/common.c
index fb588d8..269244b 100644
--- a/hw/vfio/common.c
+++ b/hw/vfio/common.c
@@ -349,7 +349,12 @@ static void vfio_listener_region_add(MemoryListener *listener,
if (int128_ge(int128_make64(iova), llend)) {
return;
}
- end = int128_get64(llend);
+
+ if (int128_eq(llend, int128_2_64())) {
+ end = UINT64_MAX;
+ } else {
+ end = int128_get64(llend);
+ }
if ((iova < container->min_iova) || ((end - 1) > container->max_iova)) {
error_report("vfio: IOMMU container %p can't map guest IOVA region"
--
2.7.0
next reply other threads:[~2016-03-21 22:00 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-03-21 22:00 Bandan Das [this message]
2016-03-21 22:34 ` [Qemu-devel] [PATCH] vfio: add check for memory region overflow condition Alex Williamson
2016-03-22 0:06 ` Bandan Das
2016-03-22 0:30 ` Alex Williamson
2016-03-22 1:54 ` Bandan Das
2016-03-22 2:16 ` Alex Williamson
2016-03-22 18:55 ` Bandan Das
2016-03-22 19:31 ` Alex Williamson
2016-03-22 20:55 ` Bandan Das
2016-03-22 3:01 ` Peter Xu
2016-03-22 19:07 ` Bandan Das
2016-03-22 19:31 ` Alex Williamson
2016-03-23 2:42 ` Peter Xu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=jpg8u1blcdp.fsf@linux.bootlegged.copy \
--to=bsd@redhat.com \
--cc=alex.williamson@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).