From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:43268) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Zx8IQ-0002J8-Lc for qemu-devel@nongnu.org; Fri, 13 Nov 2015 01:57:19 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Zx8IL-0000Ad-LP for qemu-devel@nongnu.org; Fri, 13 Nov 2015 01:57:18 -0500 Received: from mx1.redhat.com ([209.132.183.28]:39095) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Zx8IL-0000AY-Gn for qemu-devel@nongnu.org; Fri, 13 Nov 2015 01:57:13 -0500 Received: from int-mx11.intmail.prod.int.phx2.redhat.com (int-mx11.intmail.prod.int.phx2.redhat.com [10.5.11.24]) by mx1.redhat.com (Postfix) with ESMTPS id 2CE57A4526 for ; Fri, 13 Nov 2015 06:57:13 +0000 (UTC) From: Bandan Das References: <1447368949-15312-1-git-send-email-bsd@redhat.com> <1447368949-15312-3-git-send-email-bsd@redhat.com> <56451A0D.8@redhat.com> Date: Fri, 13 Nov 2015 01:57:11 -0500 In-Reply-To: <56451A0D.8@redhat.com> (Eric Blake's message of "Thu, 12 Nov 2015 16:00:29 -0700") Message-ID: MIME-Version: 1.0 Content-Type: text/plain Subject: Re: [Qemu-devel] [PATCH v2 2/2] i440fx: print an error message if user tries to enable iommu List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Eric Blake Cc: mst@redhat.com, qemu-devel@nongnu.org, armbru@redhat.com Eric Blake writes: > On 11/12/2015 03:55 PM, Bandan Das wrote: >> There's no indication of any sort that i440fx doesn't support >> "iommu=on"" >> >> Signed-off-by: Bandan Das >> --- >> hw/pci-host/piix.c | 5 +++++ >> 1 file changed, 5 insertions(+) >> > >> @@ -301,6 +302,10 @@ static void i440fx_pcihost_realize(DeviceState *dev, Error **errp) >> static void i440fx_realize(PCIDevice *dev, Error **errp) >> { >> dev->config[I440FX_SMRAM] = 0x02; >> + >> + if (object_property_get_bool(qdev_get_machine(), "iommu", NULL)) { >> + error_report("warning: i440fx doesn't support emulated iommu\n"); > > No trailing \n with error_report(). > > With that fixed (and perhaps maintainer can do it), No problem, I sent out an updated version. Thanks for the review! Bandan > Reviewed-by: Eric Blake