From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:52310) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bNT2w-0001Hm-T8 for qemu-devel@nongnu.org; Wed, 13 Jul 2016 18:54:27 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bNT2s-0005vO-Qa for qemu-devel@nongnu.org; Wed, 13 Jul 2016 18:54:25 -0400 Received: from mx1.redhat.com ([209.132.183.28]:43251) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bNT2s-0005vK-LF for qemu-devel@nongnu.org; Wed, 13 Jul 2016 18:54:22 -0400 From: Bandan Das References: <1467786055-85835-1-git-send-email-imammedo@redhat.com> <1467786055-85835-18-git-send-email-imammedo@redhat.com> Date: Wed, 13 Jul 2016 18:54:20 -0400 In-Reply-To: <1467786055-85835-18-git-send-email-imammedo@redhat.com> (Igor Mammedov's message of "Wed, 6 Jul 2016 08:20:53 +0200") Message-ID: MIME-Version: 1.0 Content-Type: text/plain Subject: Re: [Qemu-devel] [PATCH v3 17/19] target-i386: fix apic object leak when CPU is deleted List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Igor Mammedov Cc: qemu-devel@nongnu.org, pkrempa@redhat.com, ehabkost@redhat.com, mst@redhat.com, armbru@redhat.com, eduardo.otubo@profitbricks.com, marcel@redhat.com, pbonzini@redhat.com, rth@twiddle.net Igor Mammedov writes: > Signed-off-by: Igor Mammedov > --- > target-i386/cpu.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/target-i386/cpu.c b/target-i386/cpu.c > index 04c0b79..2fa445d 100644 > --- a/target-i386/cpu.c > +++ b/target-i386/cpu.c > @@ -2765,6 +2765,7 @@ static void x86_cpu_apic_create(X86CPU *cpu, Error **errp) > > object_property_add_child(OBJECT(cpu), "lapic", > OBJECT(cpu->apic_state), &error_abort); > + object_unref(OBJECT(cpu->apic_state)); Just about to write down my concern but I noticed you guys have already sorted this out :) > qdev_prop_set_uint8(cpu->apic_state, "id", cpu->apic_id); > /* TODO: convert to link<> */