From: Bandan Das <bsd@redhat.com>
To: Alex Williamson <alex.williamson@redhat.com>
Cc: "jb-gnumlists@wisemo.com" <jb-gnumlists@wisemo.com>,
Casey Leedom <leedom@chelsio.com>,
"mst@redhat.com" <mst@redhat.com>,
"qemu-devel@nongnu.org" <qemu-devel@nongnu.org>,
Anish Bhatt <anish@chelsio.com>,
Michael Boksanyi <mboksanyi@chelsio.com>,
Gabriel Laupre <glaupre@chelsio.com>,
"bsd@makefile.in" <bsd@makefile.in>
Subject: Re: [Qemu-devel] [PATCH v3] pci : Add pba_offset PCI quirk for Chelsio T5 devices
Date: Wed, 01 Jul 2015 14:27:07 -0400 [thread overview]
Message-ID: <jpgoajvag3o.fsf@redhat.com> (raw)
In-Reply-To: <1435774699.3909.18.camel@redhat.com> (Alex Williamson's message of "Wed, 01 Jul 2015 12:18:19 -0600")
Alex Williamson <alex.williamson@redhat.com> writes:
...
>> */
>> if (vendor == PCI_VENDOR_ID_CHELSIO && (device & 0xff00) == 0x5800) {
>> vdev->msix->pba_offset = 0x1000;
>> } else {
>> error_report("vfio: Hardware reports invalid configuration, "
>> "MSIX data outside of specified BAR");
>> return -EINVAL;
>> }
>> }
>> ...
>>
>> As the hardware problem is only related with the pba_offset and the purpose of the quirk is to correct the known hardware error. The table_offset has never been seen as wrong. Therefore the msix_init() sanity check should take care of a "rare" potential error as you mentioned.
>>
>> This time I'll wait for ACKs from your side before submitting a new version :)
>
> I would s/data/PBA/ in the error_report text for this version. Thanks,
Looks good to me, Gabriel + what Alex mentioned above.
Thanks,
Bandan
prev parent reply other threads:[~2015-07-01 18:27 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-06-30 21:03 [Qemu-devel] [PATCH v3] pci : Add pba_offset PCI quirk for Chelsio T5 devices Gabriel Laupre
2015-06-30 21:35 ` Alex Williamson
2015-06-30 21:58 ` Bandan Das
2015-06-30 22:28 ` Alex Williamson
2015-06-30 22:59 ` Casey Leedom
2015-07-01 1:28 ` Gabriel Laupre
2015-07-01 1:47 ` Bandan Das
2015-07-01 1:53 ` Gabriel Laupre
2015-07-01 2:13 ` Gabriel Laupre
2015-07-01 18:10 ` Gabriel Laupre
2015-07-01 18:18 ` Alex Williamson
2015-07-01 18:27 ` Bandan Das [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=jpgoajvag3o.fsf@redhat.com \
--to=bsd@redhat.com \
--cc=alex.williamson@redhat.com \
--cc=anish@chelsio.com \
--cc=bsd@makefile.in \
--cc=glaupre@chelsio.com \
--cc=jb-gnumlists@wisemo.com \
--cc=leedom@chelsio.com \
--cc=mboksanyi@chelsio.com \
--cc=mst@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).