From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:42107)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <bsd@redhat.com>) id 1ZAMj6-0006ZN-3J
	for qemu-devel@nongnu.org; Wed, 01 Jul 2015 14:27:16 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <bsd@redhat.com>) id 1ZAMj0-0001e0-IO
	for qemu-devel@nongnu.org; Wed, 01 Jul 2015 14:27:16 -0400
Received: from mx1.redhat.com ([209.132.183.28]:50200)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <bsd@redhat.com>) id 1ZAMj0-0001dN-Ct
	for qemu-devel@nongnu.org; Wed, 01 Jul 2015 14:27:10 -0400
From: Bandan Das <bsd@redhat.com>
References: <1435698210-15999-1-git-send-email-glaupre@chelsio.com>
	<jpgbnfwoo44.fsf@redhat.com>
	<8BEEA230E0FD5945BB88FC15B2A54777D0A957@nice.asicdesigners.com>
	<jpga8vg1wdt.fsf@redhat.com>
	<8BEEA230E0FD5945BB88FC15B2A54777D0B00D@nice.asicdesigners.com>
	<1435774699.3909.18.camel@redhat.com>
Date: Wed, 01 Jul 2015 14:27:07 -0400
In-Reply-To: <1435774699.3909.18.camel@redhat.com> (Alex Williamson's message
	of "Wed, 01 Jul 2015 12:18:19 -0600")
Message-ID: <jpgoajvag3o.fsf@redhat.com>
MIME-Version: 1.0
Content-Type: text/plain
Subject: Re: [Qemu-devel] [PATCH v3] pci : Add pba_offset PCI quirk for
	Chelsio T5 devices
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Alex Williamson <alex.williamson@redhat.com>
Cc: "jb-gnumlists@wisemo.com" <jb-gnumlists@wisemo.com>, Casey Leedom <leedom@chelsio.com>, "mst@redhat.com" <mst@redhat.com>, "qemu-devel@nongnu.org" <qemu-devel@nongnu.org>, Anish Bhatt <anish@chelsio.com>, Michael Boksanyi <mboksanyi@chelsio.com>, Gabriel Laupre <glaupre@chelsio.com>, "bsd@makefile.in" <bsd@makefile.in>

Alex Williamson <alex.williamson@redhat.com> writes:
...
>>          */
>>         if (vendor == PCI_VENDOR_ID_CHELSIO && (device & 0xff00) == 0x5800) {
>>             vdev->msix->pba_offset = 0x1000;
>>         } else {
>>             error_report("vfio: Hardware reports invalid configuration, "
>>                          "MSIX data outside of specified BAR");
>>             return -EINVAL;
>>         }
>>     }  
>> ...
>> 
>> As the hardware problem is only related with the pba_offset and the purpose of the quirk is to correct the known hardware error. The table_offset has never been seen as wrong. Therefore the msix_init() sanity check should take care of a "rare" potential error as you mentioned. 
>> 
>> This time I'll wait for ACKs from your side before submitting a new version :)
>
> I would s/data/PBA/ in the error_report text for this version.  Thanks,

Looks good to me, Gabriel + what Alex mentioned above.

Thanks,
Bandan