From: Bandan Das <bsd@redhat.com>
To: Gerd Hoffmann <kraxel@redhat.com>
Cc: Paolo Bonzini <pbonzini@redhat.com>,
"Vassili Karpov (malc)" <av1474@comtv.ru>,
qemu-devel@nongnu.org, Jan Kiszka <jan.kiszka@siemens.com>,
Markus Armbruster <armbru@redhat.com>
Subject: Re: [Qemu-devel] [PATCH v2 2/3] hda-codec: make mixemu selectable at runtime
Date: Fri, 06 Sep 2013 21:39:03 -0400 [thread overview]
Message-ID: <jpgr4d1e7go.fsf@aqua.home.waltham> (raw)
In-Reply-To: <1378452326.13048.7.camel@nilsson.home.kraxel.org> (Gerd Hoffmann's message of "Fri, 06 Sep 2013 09:25:26 +0200")
Gerd Hoffmann <kraxel@redhat.com> writes:
>> --- a/hw/audio/hda-codec.c
>> +++ b/hw/audio/hda-codec.c
>> @@ -118,7 +118,20 @@ static void hda_codec_parse_fmt(uint32_t format, struct audsettings *as)
>> #define QEMU_HDA_AMP_NONE (0)
>> #define QEMU_HDA_AMP_STEPS 0x4a
>>
>> +#ifdef CONFIG_MIXEMU
>> +#define PARAM mixemu
>> +#define HDA_MIXER
>> #include "hda-codec-common.h"
>> +#else
>> +/* keep the compiler quiet */
>> +static const desc_codec output_mixemu;
>> +static const desc_codec duplex_mixemu;
>> +static const desc_codec micro_mixemu;
>
> Needed? The *_mixemu variants are not referenced without CONFIG_MIXEMU
Indeed, they are not needed anymore. Thanks for the catch. I will fix this in a follow-up
post.
>> +#endif
>> +
>> +#define PARAM nomixemu
>
> #undefine HDA_MIXER
>
This is not needed as I already undef this in the header file.
>> +#include "hda-codec-common.h"
>> +
>
> cheers,
> Gerd
next prev parent reply other threads:[~2013-09-07 1:39 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-09-05 22:24 [Qemu-devel] [PATCH v2 0/3] Make mixer emulation configurable at runtime Bandan Das
2013-09-05 22:24 ` [Qemu-devel] [PATCH v2 1/3] hda-codec: refactor common definitions into a header file Bandan Das
2013-09-05 22:24 ` [Qemu-devel] [PATCH v2 2/3] hda-codec: make mixemu selectable at runtime Bandan Das
2013-09-06 7:25 ` Gerd Hoffmann
2013-09-07 1:39 ` Bandan Das [this message]
2013-09-05 22:24 ` [Qemu-devel] [PATCH v2 3/3] audio: remove CONFIG_MIXEMU configure option and enable mixemu by default Bandan Das
2013-09-06 7:35 ` Gerd Hoffmann
2013-09-07 3:42 ` Bandan Das
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=jpgr4d1e7go.fsf@aqua.home.waltham \
--to=bsd@redhat.com \
--cc=armbru@redhat.com \
--cc=av1474@comtv.ru \
--cc=jan.kiszka@siemens.com \
--cc=kraxel@redhat.com \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).