From: Bandan Das <bsd@redhat.com>
To: Gerd Hoffmann <kraxel@redhat.com>
Cc: qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH 3/5] dev-mtp: retry write for incomplete transfers
Date: Tue, 07 Aug 2018 14:15:14 -0400 [thread overview]
Message-ID: <jpgtvo69h71.fsf@linux.bootlegged.copy> (raw)
In-Reply-To: <20180807132847.gavgozyrmtmyol7u@sirius.home.kraxel.org> (Gerd Hoffmann's message of "Tue, 7 Aug 2018 15:28:47 +0200")
Gerd Hoffmann <kraxel@redhat.com> writes:
> On Fri, Jul 20, 2018 at 05:40:18PM -0400, Bandan Das wrote:
>> For large buffers, write may not copy the full buffer. For example,
>> on Linux, write imposes a limit of 0x7ffff000. Note that this does
>> not fix >4G transfers but ~>2G files will transfer successfully.
>
> Hmm, I guess it would be a good idea to write the file in smaller
> pieces, so we don't need a 2G host buffer to let the guest write
> a 2G file ...
>
> (as incremental improvement on top of this series).
>
Sounds good, I will add this to my todo list.
> cheers,
> Gerd
next prev parent reply other threads:[~2018-08-07 18:15 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-07-20 21:40 [Qemu-devel] [PATCH 0/5] usb-mtp write fixes Bandan Das
2018-07-20 21:40 ` [Qemu-devel] [PATCH 1/5] dev-mtp: add support for canceling transaction Bandan Das
2018-07-20 21:40 ` [Qemu-devel] [PATCH 2/5] dev-mtp: fix buffer allocation for writing file contents Bandan Das
2018-07-20 21:40 ` [Qemu-devel] [PATCH 3/5] dev-mtp: retry write for incomplete transfers Bandan Das
2018-08-07 13:28 ` Gerd Hoffmann
2018-08-07 18:15 ` Bandan Das [this message]
2018-10-19 9:48 ` Thomas Huth
2018-07-20 21:40 ` [Qemu-devel] [PATCH 4/5] dev-mtp: Add support for > 4GB file transfers Bandan Das
2018-07-20 21:40 ` [Qemu-devel] [PATCH 5/5] dev-mtp: rename x-root to rootdir Bandan Das
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=jpgtvo69h71.fsf@linux.bootlegged.copy \
--to=bsd@redhat.com \
--cc=kraxel@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).