From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:44693)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <bsd@redhat.com>) id 1ZvvcL-0001rn-Vd
	for qemu-devel@nongnu.org; Mon, 09 Nov 2015 18:12:54 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <bsd@redhat.com>) id 1ZvvcG-0006XI-Qa
	for qemu-devel@nongnu.org; Mon, 09 Nov 2015 18:12:53 -0500
Received: from mx1.redhat.com ([209.132.183.28]:55432)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <bsd@redhat.com>) id 1ZvvcG-0006W1-Lq
	for qemu-devel@nongnu.org; Mon, 09 Nov 2015 18:12:48 -0500
Received: from int-mx14.intmail.prod.int.phx2.redhat.com
	(int-mx14.intmail.prod.int.phx2.redhat.com [10.5.11.27])
	by mx1.redhat.com (Postfix) with ESMTPS id F0FF4351DEF
	for <qemu-devel@nongnu.org>; Mon,  9 Nov 2015 23:12:46 +0000 (UTC)
From: Bandan Das <bsd@redhat.com>
References: <1446595225-23608-1-git-send-email-bsd@redhat.com>
	<1446595225-23608-3-git-send-email-bsd@redhat.com>
	<1446713343.30393.16.camel@redhat.com>
Date: Mon, 09 Nov 2015 18:12:45 -0500
In-Reply-To: <1446713343.30393.16.camel@redhat.com> (Gerd Hoffmann's message
	of "Thu, 05 Nov 2015 09:49:03 +0100")
Message-ID: <jpgtwoupy1e.fsf@linux.bootlegged.copy>
MIME-Version: 1.0
Content-Type: text/plain
Subject: Re: [Qemu-devel] [PATCH 2/3] usb-mtp: Add support for inotify based
	file monitoring
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Gerd Hoffmann <kraxel@redhat.com>
Cc: qemu-devel@nongnu.org

Gerd Hoffmann <kraxel@redhat.com> writes:

> On Di, 2015-11-03 at 19:00 -0500, Bandan Das wrote:
>> +                    /* Add a new watch asap so as to not lose events
>> */
>
> This comment sounds like there is a race ("asap").  There isn't one,
> correct ordering (adding the watch before reading the directory) is

Hmm, seems like there's still a small window. We may not have even
started processing the event because we are still processing the earlier
ones.

> enough to make sure you don't miss anything.  You might see create
> events for objects already in the tree though, are you prepared to
> handle that?

Oh, interesting.  Current version will happily add duplicate entries.
I will add a check.

> cheers,
>   Gerd