From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:43595) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SYBbd-0007q1-EG for qemu-devel@nongnu.org; Sat, 26 May 2012 03:40:10 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1SYBbb-00059y-Pp for qemu-devel@nongnu.org; Sat, 26 May 2012 03:40:09 -0400 Received: from plane.gmane.org ([80.91.229.3]:43261) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SYBbb-00059V-JI for qemu-devel@nongnu.org; Sat, 26 May 2012 03:40:07 -0400 Received: from list by plane.gmane.org with local (Exim 4.69) (envelope-from ) id 1SYBbZ-0001dV-4u for qemu-devel@nongnu.org; Sat, 26 May 2012 09:40:05 +0200 Received: from 93-34-182-16.ip50.fastwebnet.it ([93.34.182.16]) by main.gmane.org with esmtp (Gmexim 0.1 (Debian)) id 1AlnuQ-0007hv-00 for ; Sat, 26 May 2012 09:40:05 +0200 Received: from pbonzini by 93-34-182-16.ip50.fastwebnet.it with local (Gmexim 0.1 (Debian)) id 1AlnuQ-0007hv-00 for ; Sat, 26 May 2012 09:40:05 +0200 From: Paolo Bonzini Date: Sat, 26 May 2012 09:37:44 +0200 Message-ID: References: <1338008201-29078-1-git-send-email-ronniesahlberg@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-15 Content-Transfer-Encoding: 7bit In-Reply-To: <1338008201-29078-1-git-send-email-ronniesahlberg@gmail.com> Subject: Re: [Qemu-devel] [PATCH 0/4] ISCSI: Passthough updates List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Il 26/05/2012 06:56, Ronnie Sahlberg ha scritto: > Paolo, list > > Please find a set of patches for iscsi. > > 1, The recent change to the eventsystem in iscsi is racy. If the > async connect of the socket takes longer than almost instant, the > shortcircuit trying to write directly to the socket may try to do so > before the socket is established. So we hcange the logic here and > ONLY try the shortcircuit avoiding setting up POLLOUT if we have been > fully logged in. > > This avoids the race where we might crash if the socket is not yet > connected. > > 2, Swithc to using READCAPACITY10 for MMC devices. Only SBC devices > support READCAPACITY16 so far. > > 3, Switch to use READ10 for MMC devices instead of READ16. With this > patch ISCSI and MMC devices now work correctly. > > 4, If the device is a SMC device, then force the device to be sg. We > dont support emulation as far as i know for SMV devices, so these > device types would only work for sg or iscsi passthrough anyway. The > reason we need to forcer sg is that since we can not READ from a SMC > device, we need to shortcircuit find_image_format() before it tries > to do the bdrv_pread() trying to guess what format the image is. > > With this patch I have verified I can access and manage a media > changer via iscsi-passthrough. Applied 1-2 to scsi-next branch for 1.1, 3 for 1.2. Paolo