qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Paolo Bonzini <pbonzini@redhat.com>
To: qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH] megasas: Update function megasys_scsi_uninit
Date: Tue, 31 Jul 2012 16:13:28 +0200	[thread overview]
Message-ID: <jv8p68$m14$1@dough.gmane.org> (raw)
In-Reply-To: <1343714097-545-1-git-send-email-sw@weilnetz.de>

Il 31/07/2012 07:54, Stefan Weil ha scritto:
> Commit f90c2bcdbc69e41e575f868b984c3e2de8f51bac changed
> PCIUnregisterFunc, therefore the function prototype
> needs an update.
> 
> megasas.o is currently not linked, so this bug was not
> detected by the buildbots.
> 
> Signed-off-by: Stefan Weil <sw@weilnetz.de>
> ---
>  hw/megasas.c |    3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)
> 
> diff --git a/hw/megasas.c b/hw/megasas.c
> index 833f313..5235c50 100644
> --- a/hw/megasas.c
> +++ b/hw/megasas.c
> @@ -2041,7 +2041,7 @@ static const VMStateDescription vmstate_megasas = {
>      }
>  };
>  
> -static int megasas_scsi_uninit(PCIDevice *d)
> +static void megasas_scsi_uninit(PCIDevice *d)
>  {
>      MegasasState *s = DO_UPCAST(MegasasState, dev, d);
>  
> @@ -2051,7 +2051,6 @@ static int megasas_scsi_uninit(PCIDevice *d)
>      memory_region_destroy(&s->mmio_io);
>      memory_region_destroy(&s->port_io);
>      memory_region_destroy(&s->queue_io);
> -    return 0;
>  }
>  
>  static const struct SCSIBusInfo megasas_scsi_info = {
> 

Applied to scsi-next branch, thanks.

Paolo

  reply	other threads:[~2012-07-31 14:14 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-07-31  5:54 [Qemu-devel] [PATCH] megasas: Update function megasys_scsi_uninit Stefan Weil
2012-07-31 14:13 ` Paolo Bonzini [this message]
2012-07-31 14:39 ` Andreas Färber
2012-07-31 14:43   ` Paolo Bonzini
2012-07-31 14:46     ` Andreas Färber
2012-07-31 14:50       ` Paolo Bonzini
2012-07-31 14:55         ` Andreas Färber
2012-07-31 15:15           ` Anthony Liguori
2012-07-31 15:45             ` Paolo Bonzini
2012-07-31 22:17               ` Hannes Reinecke
2012-08-01  7:38                 ` Paolo Bonzini
2012-08-01  7:54                   ` Hannes Reinecke
2012-08-01  8:01                     ` Paolo Bonzini
2012-08-01  9:15                       ` Hannes Reinecke
2012-07-31 15:16           ` Paolo Bonzini

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='jv8p68$m14$1@dough.gmane.org' \
    --to=pbonzini@redhat.com \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).