From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:53851) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SwDCv-0007mO-94 for qemu-devel@nongnu.org; Tue, 31 Jul 2012 10:14:06 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1SwDCr-0004WV-1m for qemu-devel@nongnu.org; Tue, 31 Jul 2012 10:13:57 -0400 Received: from plane.gmane.org ([80.91.229.3]:60553) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SwDCq-0004Vs-Qk for qemu-devel@nongnu.org; Tue, 31 Jul 2012 10:13:52 -0400 Received: from list by plane.gmane.org with local (Exim 4.69) (envelope-from ) id 1SwDCg-00048v-UO for qemu-devel@nongnu.org; Tue, 31 Jul 2012 16:13:42 +0200 Received: from 93-34-169-1.ip50.fastwebnet.it ([93.34.169.1]) by main.gmane.org with esmtp (Gmexim 0.1 (Debian)) id 1AlnuQ-0007hv-00 for ; Tue, 31 Jul 2012 16:13:42 +0200 Received: from pbonzini by 93-34-169-1.ip50.fastwebnet.it with local (Gmexim 0.1 (Debian)) id 1AlnuQ-0007hv-00 for ; Tue, 31 Jul 2012 16:13:42 +0200 From: Paolo Bonzini Date: Tue, 31 Jul 2012 16:13:28 +0200 Message-ID: References: <1343714097-545-1-git-send-email-sw@weilnetz.de> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-15 Content-Transfer-Encoding: 7bit In-Reply-To: <1343714097-545-1-git-send-email-sw@weilnetz.de> Subject: Re: [Qemu-devel] [PATCH] megasas: Update function megasys_scsi_uninit List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Il 31/07/2012 07:54, Stefan Weil ha scritto: > Commit f90c2bcdbc69e41e575f868b984c3e2de8f51bac changed > PCIUnregisterFunc, therefore the function prototype > needs an update. > > megasas.o is currently not linked, so this bug was not > detected by the buildbots. > > Signed-off-by: Stefan Weil > --- > hw/megasas.c | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) > > diff --git a/hw/megasas.c b/hw/megasas.c > index 833f313..5235c50 100644 > --- a/hw/megasas.c > +++ b/hw/megasas.c > @@ -2041,7 +2041,7 @@ static const VMStateDescription vmstate_megasas = { > } > }; > > -static int megasas_scsi_uninit(PCIDevice *d) > +static void megasas_scsi_uninit(PCIDevice *d) > { > MegasasState *s = DO_UPCAST(MegasasState, dev, d); > > @@ -2051,7 +2051,6 @@ static int megasas_scsi_uninit(PCIDevice *d) > memory_region_destroy(&s->mmio_io); > memory_region_destroy(&s->port_io); > memory_region_destroy(&s->queue_io); > - return 0; > } > > static const struct SCSIBusInfo megasas_scsi_info = { > Applied to scsi-next branch, thanks. Paolo