From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1NxMid-0000PX-Vg for qemu-devel@nongnu.org; Thu, 01 Apr 2010 11:54:08 -0400 Received: from [140.186.70.92] (port=32795 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1NxMia-0000NW-Pz for qemu-devel@nongnu.org; Thu, 01 Apr 2010 11:54:07 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.69) (envelope-from ) id 1NxMiZ-000704-8E for qemu-devel@nongnu.org; Thu, 01 Apr 2010 11:54:04 -0400 Received: from mail-pw0-f45.google.com ([209.85.160.45]:34110) by eggs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1NxMiY-0006zw-Vc for qemu-devel@nongnu.org; Thu, 01 Apr 2010 11:54:03 -0400 Received: by pwi6 with SMTP id 6so1097711pwi.4 for ; Thu, 01 Apr 2010 08:54:02 -0700 (PDT) MIME-Version: 1.0 In-Reply-To: <4BB408CF.9040004@codemonkey.ws> References: <20100331182031.GA5200@redhat.com> <4BB393CF.1040700@codemonkey.ws> <20100331153805.03ee142e@redhat.com> <20100331190753.GA6914@redhat.com> <4BB3A183.8000905@codemonkey.ws> <20100331224541.GB19306@hall.aurel32.net> <4BB408CF.9040004@codemonkey.ws> Date: Thu, 1 Apr 2010 18:54:01 +0300 Message-ID: Subject: Re: [Qemu-devel] Re: [PATCH] vhost: fix features ack From: Blue Swirl Content-Type: text/plain; charset=UTF-8 List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Anthony Liguori Cc: Luiz Capitulino , qemu-devel@nongnu.org, Aurelien Jarno , "Michael S. Tsirkin" On 4/1/10, Anthony Liguori wrote: > On 03/31/2010 05:45 PM, Aurelien Jarno wrote: > > > While it probably make sense to achieve this goal, it doesn't mean it > > should be done the dirty way. > > > > For example it is known for a lot of time that the solution for the > > bswap in the device code is to add a bus model doing the byteswapping. > > Removing the #ifdef by deciding "this device will only be big/little > > endian" doesn't seem to go in the right direction. > > > > > > Yeah, I'm having real trouble with the KVM regression. I thought I had it > fixed but linux-user really made a mess of things. There's no simple > solution that doesn't require quite a bit of refactoring which I'd rather do > in a less ugly way. We've already been discussing getting rid of all the > kvm_enabled() stuff and I think doing that properly is going to be needed to > handle this correctly. Strange, does linux-user use kvm.h (indirectly)?