From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([208.118.235.92]:56959)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <gceq-qemu-devel@m.gmane.org>) id 1TOrgQ-00055O-Nh
	for qemu-devel@nongnu.org; Thu, 18 Oct 2012 11:06:58 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <gceq-qemu-devel@m.gmane.org>) id 1TOrgM-0005iZ-2D
	for qemu-devel@nongnu.org; Thu, 18 Oct 2012 11:06:50 -0400
Received: from plane.gmane.org ([80.91.229.3]:57243)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <gceq-qemu-devel@m.gmane.org>) id 1TOrgL-0005iT-RH
	for qemu-devel@nongnu.org; Thu, 18 Oct 2012 11:06:45 -0400
Received: from list by plane.gmane.org with local (Exim 4.69)
	(envelope-from <gceq-qemu-devel@m.gmane.org>) id 1TOrgQ-00082p-R7
	for qemu-devel@nongnu.org; Thu, 18 Oct 2012 17:06:50 +0200
Received: from 93-34-169-1.ip50.fastwebnet.it ([93.34.169.1])
	by main.gmane.org with esmtp (Gmexim 0.1 (Debian))
	id 1AlnuQ-0007hv-00
	for <qemu-devel@nongnu.org>; Thu, 18 Oct 2012 17:06:50 +0200
Received: from pbonzini by 93-34-169-1.ip50.fastwebnet.it with local (Gmexim
	0.1 (Debian)) id 1AlnuQ-0007hv-00
	for <qemu-devel@nongnu.org>; Thu, 18 Oct 2012 17:06:50 +0200
From: Paolo Bonzini <pbonzini@redhat.com>
Date: Thu, 18 Oct 2012 17:06:33 +0200
Message-ID: <k5p5to$dmg$1@ger.gmane.org>
References: <1350572215-2231-1-git-send-email-stefanha@redhat.com>
	<1350572215-2231-5-git-send-email-stefanha@redhat.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: 7bit
In-Reply-To: <1350572215-2231-5-git-send-email-stefanha@redhat.com>
Subject: Re: [Qemu-devel] [PATCH 4/4] net: convert NetClientState to QOM
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: qemu-devel@nongnu.org

Il 18/10/2012 16:56, Stefan Hajnoczi ha scritto:
>  
> -static NetClientInfo net_tap_win32_info = {
> -    .type = NET_CLIENT_OPTIONS_KIND_TAP,
> -    .size = sizeof(TAPState),
> -    .receive = tap_receive,
> -    .cleanup = tap_cleanup,
> +#define TYPE_TAP_WIN32_NET_CLIENT "tap-win32-net-client"
> +
> +static void tap_win32_net_client_class_init(ObjectClass *klass,
> +                                            void *class_data)
> +{
> +    NetClientClass *ncc = NET_CLIENT_CLASS(klass);
> +
> +    ncc->type_str = "tap";
> +    ncc->receive = tap_receive;
> +    ncc->cleanup = tap_cleanup;
> +}
> +
> +static TypeInfo tap_win32_net_client_info = {
> +    .name = TYPE_TAP_WIN32_NET_CLIENT,
> +    .parent = TYPE_NET_CLIENT,

Why a separate type name than TYPE_NET_CLIENT?  It doesn't really matter
if the client is Unix or Win32.

Paolo