From: Manos Pitsidianakis <manos.pitsidianakis@linaro.org>
To: "Philippe Mathieu-Daudé " <philmd@linaro.org>, qemu-devel@nongnu.org
Cc: qemu-trivial@nongnu.org,
"Manos Pitsidianakis" <manos.pitsidianakis@linaro.org>,
"Michael S. Tsirkin" <mst@redhat.com>,
"Gerd Hoffmann" <kraxel@redhat.com>,
"Philippe Mathieu-Daudé " <philmd@linaro.org>
Subject: Re: [PATCH] hw/audio/virtio-snd: Remove unnecessary "exec/tswap.h" header
Date: Thu, 26 Sep 2024 14:35:10 +0300 [thread overview]
Message-ID: <kf47q.xtqbzbv0rng0@linaro.org> (raw)
In-Reply-To: <20240926102113.64890-1-philmd@linaro.org>
On Thu, 26 Sep 2024 13:21, Philippe Mathieu-Daudé <philmd@linaro.org> wrote:
>We were including the "exec/tswap.h" header to get
>target_words_bigendian() declaration, but since commit a276ec8e26
>("hw/audio/virtio-snd: Always use little endian audio format")
>removed this method call, we don't need this header anymore.
>
>Signed-off-by: Philippe Mathieu-Daudé <philmd@linaro.org>
>---
> hw/audio/virtio-snd.c | 1 -
> 1 file changed, 1 deletion(-)
>
>diff --git a/hw/audio/virtio-snd.c b/hw/audio/virtio-snd.c
>index 69838181dd..c5581d7b3d 100644
>--- a/hw/audio/virtio-snd.c
>+++ b/hw/audio/virtio-snd.c
>@@ -20,7 +20,6 @@
> #include "qemu/log.h"
> #include "qemu/error-report.h"
> #include "qemu/lockable.h"
>-#include "exec/tswap.h"
> #include "sysemu/runstate.h"
> #include "trace.h"
> #include "qapi/error.h"
>--
>2.45.2
>
Reviewed-by: Manos Pitsidianakis <manos.pitsidianakis@linaro.org>
next prev parent reply other threads:[~2024-09-26 11:35 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-09-26 10:21 [PATCH] hw/audio/virtio-snd: Remove unnecessary "exec/tswap.h" header Philippe Mathieu-Daudé
2024-09-26 11:35 ` Manos Pitsidianakis [this message]
2024-10-03 18:59 ` Richard Henderson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=kf47q.xtqbzbv0rng0@linaro.org \
--to=manos.pitsidianakis@linaro.org \
--cc=kraxel@redhat.com \
--cc=mst@redhat.com \
--cc=philmd@linaro.org \
--cc=qemu-devel@nongnu.org \
--cc=qemu-trivial@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).