From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([208.118.235.92]:47708)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <gceq-qemu-devel@m.gmane.org>) id 1UNgiN-00028e-Ak
	for qemu-devel@nongnu.org; Thu, 04 Apr 2013 05:44:18 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <gceq-qemu-devel@m.gmane.org>) id 1UNgiI-0003y7-CV
	for qemu-devel@nongnu.org; Thu, 04 Apr 2013 05:44:15 -0400
Received: from plane.gmane.org ([80.91.229.3]:34893)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <gceq-qemu-devel@m.gmane.org>) id 1UNgiI-0003wQ-5t
	for qemu-devel@nongnu.org; Thu, 04 Apr 2013 05:44:10 -0400
Received: from list by plane.gmane.org with local (Exim 4.69)
	(envelope-from <gceq-qemu-devel@m.gmane.org>) id 1UNgic-0005vb-FT
	for qemu-devel@nongnu.org; Thu, 04 Apr 2013 11:44:30 +0200
Received: from 93-34-176-20.ip50.fastwebnet.it ([93.34.176.20])
	by main.gmane.org with esmtp (Gmexim 0.1 (Debian))
	id 1AlnuQ-0007hv-00
	for <qemu-devel@nongnu.org>; Thu, 04 Apr 2013 11:44:30 +0200
Received: from pbonzini by 93-34-176-20.ip50.fastwebnet.it with local (Gmexim
	0.1 (Debian)) id 1AlnuQ-0007hv-00
	for <qemu-devel@nongnu.org>; Thu, 04 Apr 2013 11:44:30 +0200
From: Paolo Bonzini <pbonzini@redhat.com>
Date: Thu, 04 Apr 2013 11:43:52 +0200
Message-ID: <kjji0n$bmf$1@ger.gmane.org>
References: <1364146041-27041-1-git-send-email-rabin@rab.in>
	<1364146041-27041-5-git-send-email-rabin@rab.in>
Mime-Version: 1.0
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: 7bit
In-Reply-To: <1364146041-27041-5-git-send-email-rabin@rab.in>
Subject: Re: [Qemu-devel] [PATCHv2 4/6] dump: fix up memory mapping
	dependencies / stub
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: qemu-devel@nongnu.org

Il 24/03/2013 18:27, Rabin Vincent ha scritto:
> dump.c won't build without the functions from memory_mapping.c (and
> memory_mapping-stub.c does not help there), so build memory_mapping.c
> when CONFIG_HAVE_CORE_DUMP is set.
> 
>   dump.c:84: undefined reference to `memory_mapping_list_free'
>   dump.c:819: undefined reference to `memory_mapping_list_init'
>   dump.c:827: undefined reference to `memory_mapping_filter'
> 
> Allow memory_mapping-stub.c to instead be used for targets which do not
> set CONFIG_HAVE_GET_MEMORY_MAPPING.

The right fix is to add these to memory_mapping-stub.c.

Paolo