From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1OB0YE-0000on-NX
	for qemu-devel@nongnu.org; Sun, 09 May 2010 03:03:46 -0400
Received: from [140.186.70.92] (port=49899 helo=eggs.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1OB0Y8-0000n4-1T
	for qemu-devel@nongnu.org; Sun, 09 May 2010 03:03:45 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.69)
	(envelope-from <blauwirbel@gmail.com>) id 1OB0Y4-0001hm-8w
	for qemu-devel@nongnu.org; Sun, 09 May 2010 03:03:39 -0400
Received: from mail-pw0-f45.google.com ([209.85.160.45]:56207)
	by eggs.gnu.org with esmtp (Exim 4.69)
	(envelope-from <blauwirbel@gmail.com>) id 1OB0Y3-0001hM-SO
	for qemu-devel@nongnu.org; Sun, 09 May 2010 03:03:36 -0400
Received: by pwj9 with SMTP id 9so971459pwj.4
	for <qemu-devel@nongnu.org>; Sun, 09 May 2010 00:03:34 -0700 (PDT)
MIME-Version: 1.0
In-Reply-To: <1273267256-23205-1-git-send-email-weil@mail.berlios.de>
References: <w2xf43fc5581005070933z6e6b3035m3a66659397e93b15@mail.gmail.com>
	<1273267256-23205-1-git-send-email-weil@mail.berlios.de>
Date: Sun, 9 May 2010 10:03:33 +0300
Message-ID: <l2lf43fc5581005090003rad0a5c71nd62175ebc9989647@mail.gmail.com>
From: Blue Swirl <blauwirbel@gmail.com>
Content-Type: text/plain; charset=UTF-8
Subject: [Qemu-devel] Re: [PATCH] mips-dis: Add missing static attributes
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Stefan Weil <weil@mail.berlios.de>
Cc: QEMU Developers <qemu-devel@nongnu.org>

Thanks, applied.

On 5/8/10, Stefan Weil <weil@mail.berlios.de> wrote:
> mips_abi_choices and mips_arch_choices are only used locally.
>
>  Signed-off-by: Stefan Weil <weil@mail.berlios.de>
>  ---
>   mips-dis.c |    4 ++--
>   1 files changed, 2 insertions(+), 2 deletions(-)
>
>  diff --git a/mips-dis.c b/mips-dis.c
>
> index 169169c..ae64543 100644
>
> --- a/mips-dis.c
>  +++ b/mips-dis.c
>  @@ -3035,7 +3035,7 @@ struct mips_abi_choice
>    const char * const *fpr_names;
>   };
>
>  -struct mips_abi_choice mips_abi_choices[] =
>  +static struct mips_abi_choice mips_abi_choices[] =
>   {
>    { "numeric", mips_gpr_names_numeric, mips_fpr_names_numeric },
>    { "32", mips_gpr_names_oldabi, mips_fpr_names_32 },
>  @@ -3086,7 +3086,7 @@ struct mips_arch_choice
>
>   #define ARRAY_SIZE(a) (sizeof(a) / sizeof(a[0]))
>
>
> -const struct mips_arch_choice mips_arch_choices[] =
>  +static const struct mips_arch_choice mips_arch_choices[] =
>   {
>    { "numeric", 0, 0, 0, 0,
>      mips_cp0_names_numeric, NULL, 0, mips_hwr_names_numeric },
>  --
>  1.7.0
>
>