* [Qemu-devel] target arm fstat64 bug
@ 2008-07-16 20:39 matthieu castet
2008-07-19 8:39 ` [Qemu-devel] " matthieu castet
2008-07-19 9:49 ` [Qemu-devel] " andrzej zaborowski
0 siblings, 2 replies; 3+ messages in thread
From: matthieu castet @ 2008-07-16 20:39 UTC (permalink / raw)
To: qemu-devel
Hi,
it seems there a problem with fstat64 struct. __pad2 should be 4 not 8 :
before it was :
unsigned short st_rdev;
unsigned char __pad3[10];
now sizeof st_rdev = 8, so we take 6 bytes to __pad3.
This match linux kernel declaration.
Index: linux-user/syscall_defs.h
===================================================================
--- linux-user/syscall_defs.h (revision 4881)
+++ linux-user/syscall_defs.h (working copy)
@@ -962,7 +962,7 @@
abi_ulong st_gid;
unsigned long long st_rdev;
- unsigned int __pad2[2];
+ unsigned int __pad2;
long long st_size;
abi_ulong st_blksize;
^ permalink raw reply [flat|nested] 3+ messages in thread* [Qemu-devel] Re: target arm fstat64 bug 2008-07-16 20:39 [Qemu-devel] target arm fstat64 bug matthieu castet @ 2008-07-19 8:39 ` matthieu castet 2008-07-19 9:49 ` [Qemu-devel] " andrzej zaborowski 1 sibling, 0 replies; 3+ messages in thread From: matthieu castet @ 2008-07-19 8:39 UTC (permalink / raw) To: qemu-devel Hi, any comment on this ? You can look at http://git.kernel.org/?p=linux/kernel/git/torvalds/linux-2.6.git \ ;a=blob;f=include/asm-arm/stat.h;h=42c0c13999d5ffa4f8458d2825cd121a41dd8595; \ hb=HEAD to see the kernel header and compare with qemu one. ^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [Qemu-devel] target arm fstat64 bug 2008-07-16 20:39 [Qemu-devel] target arm fstat64 bug matthieu castet 2008-07-19 8:39 ` [Qemu-devel] " matthieu castet @ 2008-07-19 9:49 ` andrzej zaborowski 1 sibling, 0 replies; 3+ messages in thread From: andrzej zaborowski @ 2008-07-19 9:49 UTC (permalink / raw) To: qemu-devel 2008/7/16 matthieu castet <castet.matthieu@free.fr>: > Hi, > > it seems there a problem with fstat64 struct. __pad2 should be 4 not 8 : > before it was : > unsigned short st_rdev; > unsigned char __pad3[10]; > now sizeof st_rdev = 8, so we take 6 bytes to __pad3. > This match linux kernel declaration. > > Index: linux-user/syscall_defs.h > =================================================================== > --- linux-user/syscall_defs.h (revision 4881) > +++ linux-user/syscall_defs.h (working copy) > @@ -962,7 +962,7 @@ > abi_ulong st_gid; > > unsigned long long st_rdev; > - unsigned int __pad2[2]; > + unsigned int __pad2; Is it ok to use int here at all? Also in the kernel I'm looking at there's no padding between .st_blksize and .st_blocks. Regards ^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2008-07-19 9:49 UTC | newest] Thread overview: 3+ messages (download: mbox.gz follow: Atom feed -- links below jump to the message on this page -- 2008-07-16 20:39 [Qemu-devel] target arm fstat64 bug matthieu castet 2008-07-19 8:39 ` [Qemu-devel] " matthieu castet 2008-07-19 9:49 ` [Qemu-devel] " andrzej zaborowski
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).