qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Christophe de Dinechin <dinechin@redhat.com>
To: "Philippe Mathieu-Daudé" <philmd@redhat.com>
Cc: "Eduardo Habkost" <ehabkost@redhat.com>,
	"Michael S. Tsirkin" <mst@redhat.com>,
	qemu-devel@nongnu.org, "Markus Armbruster" <armbru@redhat.com>,
	"Dr. David Alan Gilbert" <dgilbert@redhat.com>,
	"Marc-André Lureau" <marcandre.lureau@redhat.com>,
	kraxel@redhat.com, "Cleber Rosa" <crosa@redhat.com>,
	"Paolo Bonzini" <pbonzini@redhat.com>,
	"Richard Henderson" <rth@twiddle.net>
Subject: Re: [PATCH 2/7] build: fix device module builds
Date: Wed, 29 Jul 2020 18:01:57 +0200	[thread overview]
Message-ID: <lyy2n2e2dm.fsf@redhat.com> (raw)
In-Reply-To: <84be9a34-9f87-1660-3a43-aea72d9496cd@redhat.com>


On 2020-07-28 at 18:37 CEST, Philippe Mathieu-Daudé wrote...
> On 7/23/20 7:46 PM, Christophe de Dinechin wrote:
>> From: Gerd Hoffmann <kraxel@redhat.com>
>>
>> See comment.  Feels quite hackish.  Better ideas anyone?
>
> I don't understand this patch, how is it related to the rest of
> your series?

It's a leftover from an earlier workaround. For some reason, only some
spurious submodule changes remained over time. That patch can now be
dropped, I believe.

>
>>
>> Signed-off-by: Gerd Hoffmann <kraxel@redhat.com>
>> Signed-off-by: Christophe de Dinechin <dinechin@redhat.com>
>> ---
>>  dtc           | 2 +-
>>  roms/SLOF     | 2 +-
>>  roms/openbios | 2 +-
>>  roms/opensbi  | 2 +-
>>  roms/seabios  | 2 +-
>>  slirp         | 2 +-
>>  6 files changed, 6 insertions(+), 6 deletions(-)
>>
>> diff --git a/dtc b/dtc
>> index 85e5d83984..88f18909db 160000
>> --- a/dtc
>> +++ b/dtc
>> @@ -1 +1 @@
>> -Subproject commit 85e5d839847af54efab170f2b1331b2a6421e647
>> +Subproject commit 88f18909db731a627456f26d779445f84e449536
>> diff --git a/roms/SLOF b/roms/SLOF
>> index e18ddad851..9546892a80 160000
>> --- a/roms/SLOF
>> +++ b/roms/SLOF
>> @@ -1 +1 @@
>> -Subproject commit e18ddad8516ff2cfe36ec130200318f7251aa78c
>> +Subproject commit 9546892a80d5a4c73deea6719de46372f007f4a6
>> diff --git a/roms/openbios b/roms/openbios
>> index 75fbb41d28..7e5b89e429 160000
>> --- a/roms/openbios
>> +++ b/roms/openbios
>> @@ -1 +1 @@
>> -Subproject commit 75fbb41d2857d93208c74a8e0228b29fd7bf04c0
>> +Subproject commit 7e5b89e4295063d8eba55b9c8ce8bc681c2d129a
>> diff --git a/roms/opensbi b/roms/opensbi
>> index 9f1b72ce66..be92da280d 160000
>> --- a/roms/opensbi
>> +++ b/roms/opensbi
>> @@ -1 +1 @@
>> -Subproject commit 9f1b72ce66d659e91013b358939e832fb27223f5
>> +Subproject commit be92da280d87c38a2e0adc5d3f43bab7b5468f09
>> diff --git a/roms/seabios b/roms/seabios
>> index 88ab0c1552..f21b5a4aeb 160000
>> --- a/roms/seabios
>> +++ b/roms/seabios
>> @@ -1 +1 @@
>> -Subproject commit 88ab0c15525ced2eefe39220742efe4769089ad8
>> +Subproject commit f21b5a4aeb020f2a5e2c6503f906a9349dd2f069
>> diff --git a/slirp b/slirp
>> index 2faae0f778..126c04acba 160000
>> --- a/slirp
>> +++ b/slirp
>> @@ -1 +1 @@
>> -Subproject commit 2faae0f778f818fadc873308f983289df697eb93
>> +Subproject commit 126c04acbabd7ad32c2b018fe10dfac2a3bc1210
>>


--
Cheers,
Christophe de Dinechin (IRC c3d)



  reply	other threads:[~2020-07-29 16:05 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-07-23 17:46 [PATCH 0/7] Make SPICE a load module Christophe de Dinechin
2020-07-23 17:46 ` [PATCH 1/7] spice: simplify chardev setup Christophe de Dinechin
2020-07-23 17:46 ` [PATCH 2/7] build: fix device module builds Christophe de Dinechin
2020-07-28 16:37   ` Philippe Mathieu-Daudé
2020-07-29 16:01     ` Christophe de Dinechin [this message]
2020-07-23 17:46 ` [PATCH 3/7] minikconf: Pass variables for modules Christophe de Dinechin
2020-08-04  6:19   ` Gerd Hoffmann
2020-07-23 17:46 ` [PATCH 4/7] spice: Make spice a module configuration Christophe de Dinechin
2020-08-04  6:26   ` Gerd Hoffmann
2020-07-23 17:46 ` [PATCH 5/7] spice: Move all the spice-related code in spice-app.so Christophe de Dinechin
2020-08-04 10:05   ` Gerd Hoffmann
2020-07-23 17:46 ` [PATCH 6/7] build: Add SPICE_CFLAGS and SPICE_LIBS to relevant files Christophe de Dinechin
2020-08-04 10:06   ` Gerd Hoffmann
2020-07-23 17:46 ` [PATCH 7/7] spice: Call qemu spice functions indirectly Christophe de Dinechin
2020-07-27 17:38   ` Dr. David Alan Gilbert
2020-08-04 10:25     ` Gerd Hoffmann
2020-08-04 10:18   ` Gerd Hoffmann

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=lyy2n2e2dm.fsf@redhat.com \
    --to=dinechin@redhat.com \
    --cc=armbru@redhat.com \
    --cc=crosa@redhat.com \
    --cc=dgilbert@redhat.com \
    --cc=ehabkost@redhat.com \
    --cc=kraxel@redhat.com \
    --cc=marcandre.lureau@redhat.com \
    --cc=mst@redhat.com \
    --cc=pbonzini@redhat.com \
    --cc=philmd@redhat.com \
    --cc=qemu-devel@nongnu.org \
    --cc=rth@twiddle.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).