qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Manos Pitsidianakis <manos.pitsidianakis@linaro.org>
To: qemu-devel@nongnu.org
Cc: <axelheider@git.sr.ht>, qemu-trivial@nongnu.org
Subject: Re: [PATCH qemu.git 1/1] docs/devel/reset: add missing words
Date: Sun, 27 Oct 2024 12:02:04 +0200	[thread overview]
Message-ID: <m0ew1.ywldxlj9rdms@linaro.org> (raw)
In-Reply-To: <172998683323.20070.572834413126431721-1@git.sr.ht>

Hello Axel,

On Thu, 17 Oct 2024 20:58, ~axelheider <axelheider@git.sr.ht> wrote:
>From: Axel Heider <axel.heider@codasip.com>
>
>Signed-off-by: Axel Heider <axel.heider@codasip.com>
>---
> docs/devel/reset.rst | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
>diff --git a/docs/devel/reset.rst b/docs/devel/reset.rst
>index 74c7c0171a..3e64a7259f 100644
>--- a/docs/devel/reset.rst
>+++ b/docs/devel/reset.rst
>@@ -286,7 +286,7 @@ every reset child of the given resettable object. All children must be
> resettable too. Additional parameters (a reset type and an opaque pointer) must
> be passed to the callback too.
> 
>-In ``DeviceClass`` and ``BusClass`` the ``ResettableState`` is located
>+In ``DeviceClass`` and ``BusClass`` the ``ResettableState`` is located in the
> ``DeviceState`` and ``BusState`` structure. ``child_foreach()`` is implemented
> to follow the bus hierarchy; for a bus, it calls the function on every child
> device; for a device, it calls the function on every bus child. When we reset
>-- 
>2.45.2
>

FYI: the `[PATCH ...]` part of the patch subject does not need the 
`qemu.git` string inside it, I suspect it was added by some tooling you 
were using however.

If you decide to spin this patch in a new version I suggest also making 
this separate change: (adding a plural `s` suffix at `structure`)

- ``DeviceState`` and ``BusState`` structure. ``child_foreach()`` is implemented
+ ``DeviceState`` and ``BusState`` structures. ``child_foreach()`` is implemented


Reviewed-by: Manos Pitsidianakis <manos.pitsidianakis@linaro.org>


      reply	other threads:[~2024-10-27 10:10 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-10-26 23:53 [PATCH qemu.git 0/1] docs/devel/reset: add missing words ~axelheider
2024-10-17 17:58 ` [PATCH qemu.git 1/1] " ~axelheider
2024-10-27 10:02   ` Manos Pitsidianakis [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=m0ew1.ywldxlj9rdms@linaro.org \
    --to=manos.pitsidianakis@linaro.org \
    --cc=axelheider@git.sr.ht \
    --cc=qemu-devel@nongnu.org \
    --cc=qemu-trivial@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).