* [PATCH qemu.git 0/1] docs/devel/reset: add missing words
@ 2024-10-26 23:53 ~axelheider
2024-10-17 17:58 ` [PATCH qemu.git 1/1] " ~axelheider
0 siblings, 1 reply; 3+ messages in thread
From: ~axelheider @ 2024-10-26 23:53 UTC (permalink / raw)
To: qemu-devel; +Cc: qemu-trivial
Add missing words in documentation
Axel Heider (1):
docs/devel/reset: add missing words
docs/devel/reset.rst | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
--
2.45.2
^ permalink raw reply [flat|nested] 3+ messages in thread
* [PATCH qemu.git 1/1] docs/devel/reset: add missing words
2024-10-26 23:53 [PATCH qemu.git 0/1] docs/devel/reset: add missing words ~axelheider
@ 2024-10-17 17:58 ` ~axelheider
2024-10-27 10:02 ` Manos Pitsidianakis
0 siblings, 1 reply; 3+ messages in thread
From: ~axelheider @ 2024-10-17 17:58 UTC (permalink / raw)
To: qemu-devel; +Cc: qemu-trivial
From: Axel Heider <axel.heider@codasip.com>
Signed-off-by: Axel Heider <axel.heider@codasip.com>
---
docs/devel/reset.rst | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/docs/devel/reset.rst b/docs/devel/reset.rst
index 74c7c0171a..3e64a7259f 100644
--- a/docs/devel/reset.rst
+++ b/docs/devel/reset.rst
@@ -286,7 +286,7 @@ every reset child of the given resettable object. All children must be
resettable too. Additional parameters (a reset type and an opaque pointer) must
be passed to the callback too.
-In ``DeviceClass`` and ``BusClass`` the ``ResettableState`` is located
+In ``DeviceClass`` and ``BusClass`` the ``ResettableState`` is located in the
``DeviceState`` and ``BusState`` structure. ``child_foreach()`` is implemented
to follow the bus hierarchy; for a bus, it calls the function on every child
device; for a device, it calls the function on every bus child. When we reset
--
2.45.2
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH qemu.git 1/1] docs/devel/reset: add missing words
2024-10-17 17:58 ` [PATCH qemu.git 1/1] " ~axelheider
@ 2024-10-27 10:02 ` Manos Pitsidianakis
0 siblings, 0 replies; 3+ messages in thread
From: Manos Pitsidianakis @ 2024-10-27 10:02 UTC (permalink / raw)
To: qemu-devel; +Cc: axelheider, qemu-trivial
Hello Axel,
On Thu, 17 Oct 2024 20:58, ~axelheider <axelheider@git.sr.ht> wrote:
>From: Axel Heider <axel.heider@codasip.com>
>
>Signed-off-by: Axel Heider <axel.heider@codasip.com>
>---
> docs/devel/reset.rst | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
>diff --git a/docs/devel/reset.rst b/docs/devel/reset.rst
>index 74c7c0171a..3e64a7259f 100644
>--- a/docs/devel/reset.rst
>+++ b/docs/devel/reset.rst
>@@ -286,7 +286,7 @@ every reset child of the given resettable object. All children must be
> resettable too. Additional parameters (a reset type and an opaque pointer) must
> be passed to the callback too.
>
>-In ``DeviceClass`` and ``BusClass`` the ``ResettableState`` is located
>+In ``DeviceClass`` and ``BusClass`` the ``ResettableState`` is located in the
> ``DeviceState`` and ``BusState`` structure. ``child_foreach()`` is implemented
> to follow the bus hierarchy; for a bus, it calls the function on every child
> device; for a device, it calls the function on every bus child. When we reset
>--
>2.45.2
>
FYI: the `[PATCH ...]` part of the patch subject does not need the
`qemu.git` string inside it, I suspect it was added by some tooling you
were using however.
If you decide to spin this patch in a new version I suggest also making
this separate change: (adding a plural `s` suffix at `structure`)
- ``DeviceState`` and ``BusState`` structure. ``child_foreach()`` is implemented
+ ``DeviceState`` and ``BusState`` structures. ``child_foreach()`` is implemented
Reviewed-by: Manos Pitsidianakis <manos.pitsidianakis@linaro.org>
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2024-10-27 10:10 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-10-26 23:53 [PATCH qemu.git 0/1] docs/devel/reset: add missing words ~axelheider
2024-10-17 17:58 ` [PATCH qemu.git 1/1] " ~axelheider
2024-10-27 10:02 ` Manos Pitsidianakis
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).