qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Darren Kenny <darren.kenny@oracle.com>
To: Alexander Bulekov <alxndr@bu.edu>, qemu-devel@nongnu.org
Cc: Laurent Vivier <lvivier@redhat.com>,
	Thomas Huth <thuth@redhat.com>,
	f4bug@amsat.org, Alexander Bulekov <alxndr@bu.edu>,
	Bandan Das <bsd@redhat.com>,
	Stefan Hajnoczi <stefanha@redhat.com>,
	Paolo Bonzini <pbonzini@redhat.com>
Subject: Re: [PATCH] fuzz: add a am53c974 generic-fuzzer config
Date: Mon, 15 Mar 2021 11:44:12 +0000	[thread overview]
Message-ID: <m21rcgtzeb.fsf@oracle.com> (raw)
In-Reply-To: <20210314055637.5239-1-alxndr@bu.edu>

On Sunday, 2021-03-14 at 00:56:37 -05, Alexander Bulekov wrote:
> Signed-off-by: Alexander Bulekov <alxndr@bu.edu>

Code-wise looks fine to me:

Reviewed-by: Darren Kenny <darren.kenny@oracle.com>

Thanks,

Darren

> ---
>
> Fuzzing this device might lead to better coverage over the general scsi
> code.
>
>  tests/qtest/fuzz/generic_fuzz_configs.h | 6 ++++++
>  1 file changed, 6 insertions(+)
>
> diff --git a/tests/qtest/fuzz/generic_fuzz_configs.h b/tests/qtest/fuzz/generic_fuzz_configs.h
> index 5d599765c4..3f4f4d0ec5 100644
> --- a/tests/qtest/fuzz/generic_fuzz_configs.h
> +++ b/tests/qtest/fuzz/generic_fuzz_configs.h
> @@ -208,6 +208,12 @@ const generic_fuzz_config predefined_configs[] = {
>          .args = "-machine q35 -nodefaults -device megasas -device scsi-cd,drive=null0 "
>          "-blockdev driver=null-co,read-zeroes=on,node-name=null0",
>          .objects = "megasas*",
> +    },{
> +        .name = "am53c974",
> +        .args = "-device am53c974,id=scsi -device scsi-hd,drive=disk0 "
> +                 "-drive id=disk0,if=none,file=null-co://,format=raw "
> +                 "-nodefaults",
> +        .objects = "*esp* *scsi* *am53c974*",
>      },{
>          .name = "ac97",
>          .args = "-machine q35 -nodefaults "
> -- 
> 2.27.0


      reply	other threads:[~2021-03-15 11:46 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-03-14  5:56 [PATCH] fuzz: add a am53c974 generic-fuzzer config Alexander Bulekov
2021-03-15 11:44 ` Darren Kenny [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=m21rcgtzeb.fsf@oracle.com \
    --to=darren.kenny@oracle.com \
    --cc=alxndr@bu.edu \
    --cc=bsd@redhat.com \
    --cc=f4bug@amsat.org \
    --cc=lvivier@redhat.com \
    --cc=pbonzini@redhat.com \
    --cc=qemu-devel@nongnu.org \
    --cc=stefanha@redhat.com \
    --cc=thuth@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).