* [PATCH] fuzz: add a am53c974 generic-fuzzer config
@ 2021-03-14 5:56 Alexander Bulekov
2021-03-15 11:44 ` Darren Kenny
0 siblings, 1 reply; 2+ messages in thread
From: Alexander Bulekov @ 2021-03-14 5:56 UTC (permalink / raw)
To: qemu-devel
Cc: Laurent Vivier, Thomas Huth, Alexander Bulekov, f4bug,
darren.kenny, Bandan Das, Stefan Hajnoczi, Paolo Bonzini
Signed-off-by: Alexander Bulekov <alxndr@bu.edu>
---
Fuzzing this device might lead to better coverage over the general scsi
code.
tests/qtest/fuzz/generic_fuzz_configs.h | 6 ++++++
1 file changed, 6 insertions(+)
diff --git a/tests/qtest/fuzz/generic_fuzz_configs.h b/tests/qtest/fuzz/generic_fuzz_configs.h
index 5d599765c4..3f4f4d0ec5 100644
--- a/tests/qtest/fuzz/generic_fuzz_configs.h
+++ b/tests/qtest/fuzz/generic_fuzz_configs.h
@@ -208,6 +208,12 @@ const generic_fuzz_config predefined_configs[] = {
.args = "-machine q35 -nodefaults -device megasas -device scsi-cd,drive=null0 "
"-blockdev driver=null-co,read-zeroes=on,node-name=null0",
.objects = "megasas*",
+ },{
+ .name = "am53c974",
+ .args = "-device am53c974,id=scsi -device scsi-hd,drive=disk0 "
+ "-drive id=disk0,if=none,file=null-co://,format=raw "
+ "-nodefaults",
+ .objects = "*esp* *scsi* *am53c974*",
},{
.name = "ac97",
.args = "-machine q35 -nodefaults "
--
2.27.0
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] fuzz: add a am53c974 generic-fuzzer config
2021-03-14 5:56 [PATCH] fuzz: add a am53c974 generic-fuzzer config Alexander Bulekov
@ 2021-03-15 11:44 ` Darren Kenny
0 siblings, 0 replies; 2+ messages in thread
From: Darren Kenny @ 2021-03-15 11:44 UTC (permalink / raw)
To: Alexander Bulekov, qemu-devel
Cc: Laurent Vivier, Thomas Huth, f4bug, Alexander Bulekov, Bandan Das,
Stefan Hajnoczi, Paolo Bonzini
On Sunday, 2021-03-14 at 00:56:37 -05, Alexander Bulekov wrote:
> Signed-off-by: Alexander Bulekov <alxndr@bu.edu>
Code-wise looks fine to me:
Reviewed-by: Darren Kenny <darren.kenny@oracle.com>
Thanks,
Darren
> ---
>
> Fuzzing this device might lead to better coverage over the general scsi
> code.
>
> tests/qtest/fuzz/generic_fuzz_configs.h | 6 ++++++
> 1 file changed, 6 insertions(+)
>
> diff --git a/tests/qtest/fuzz/generic_fuzz_configs.h b/tests/qtest/fuzz/generic_fuzz_configs.h
> index 5d599765c4..3f4f4d0ec5 100644
> --- a/tests/qtest/fuzz/generic_fuzz_configs.h
> +++ b/tests/qtest/fuzz/generic_fuzz_configs.h
> @@ -208,6 +208,12 @@ const generic_fuzz_config predefined_configs[] = {
> .args = "-machine q35 -nodefaults -device megasas -device scsi-cd,drive=null0 "
> "-blockdev driver=null-co,read-zeroes=on,node-name=null0",
> .objects = "megasas*",
> + },{
> + .name = "am53c974",
> + .args = "-device am53c974,id=scsi -device scsi-hd,drive=disk0 "
> + "-drive id=disk0,if=none,file=null-co://,format=raw "
> + "-nodefaults",
> + .objects = "*esp* *scsi* *am53c974*",
> },{
> .name = "ac97",
> .args = "-machine q35 -nodefaults "
> --
> 2.27.0
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2021-03-15 11:46 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2021-03-14 5:56 [PATCH] fuzz: add a am53c974 generic-fuzzer config Alexander Bulekov
2021-03-15 11:44 ` Darren Kenny
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).