From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([208.118.235.92]:45775)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <morita.kazutaka@gmail.com>) id 1UVHGu-00024F-7F
	for qemu-devel@nongnu.org; Thu, 25 Apr 2013 04:11:23 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <morita.kazutaka@gmail.com>) id 1UVHGp-0003sl-9j
	for qemu-devel@nongnu.org; Thu, 25 Apr 2013 04:11:15 -0400
Received: from mail-pb0-x233.google.com ([2607:f8b0:400e:c01::233]:43060)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <morita.kazutaka@gmail.com>) id 1UVHGp-0003sa-3M
	for qemu-devel@nongnu.org; Thu, 25 Apr 2013 04:11:11 -0400
Received: by mail-pb0-f51.google.com with SMTP id rr4so713128pbb.10
	for <qemu-devel@nongnu.org>; Thu, 25 Apr 2013 01:11:10 -0700 (PDT)
Date: Thu, 25 Apr 2013 17:11:04 +0900
Message-ID: <m24nevkp2f.wl%morita.kazutaka@gmail.com>
From: MORITA Kazutaka <morita.kazutaka@gmail.com>
In-Reply-To: <5178AD4A.6050306@gmail.com>
References: <1366822079-6582-1-git-send-email-namei.unix@gmail.com>
	<5178AD4A.6050306@gmail.com>
MIME-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka")
Content-Type: text/plain; charset=US-ASCII
Subject: Re: [Qemu-devel] [sheepdog] [PATCH v2] sheepdog: fix loadvm
	operation
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Liu Yuan <namei.unix@gmail.com>
Cc: Kevin Wolf <kwolf@redhat.com>, sheepdog@lists.wpkg.org, qemu-devel@nongnu.org, Stefan Hajnoczi <stefanha@redhat.com>

At Thu, 25 Apr 2013 12:12:58 +0800,
Liu Yuan wrote:
> 
> On 04/25/2013 12:47 AM, Liu Yuan wrote:
> > - don't break old behavior if we boot up on the snapshot by using s->reverted
> >    to indicate if we delete working VDI successfully
> 
> If we implement 'boot from snapshot' == loadvm snapshot, we don't need
> s->reverted. What do you think, Kazutaka? With this idea, qemu -hda
> sheepdog:test:id will be virtually the same as qemu -hda sheepdog:test
> -loadvm id.
> 
> I don't understand the usecase for snapshting current workding VDI and
> then restore to the specified snapshot.

Are you suggesting that booting from snapshot should discard the
current state like savevm?  If yes, it looks okay to me.

Thanks,

Kazutaka