From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([208.118.235.92]:35720)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <whitebox@nefkom.net>) id 1S3x8W-0005gF-S4
	for qemu-devel@nongnu.org; Sat, 03 Mar 2012 17:09:10 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <whitebox@nefkom.net>) id 1S3x8T-00087J-AB
	for qemu-devel@nongnu.org; Sat, 03 Mar 2012 17:09:08 -0500
Received: from mail-out.m-online.net ([212.18.0.9]:38218)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <whitebox@nefkom.net>) id 1S3x8T-00084Z-3e
	for qemu-devel@nongnu.org; Sat, 03 Mar 2012 17:09:05 -0500
From: Andreas Schwab <schwab@linux-m68k.org>
References: <4F4B9E6B.2020405@suse.de>
	<CAFEAcA_Qe3R36RF+2s+HpUjDtqoyrp2FPumOrTTQr+aXLJhZbw@mail.gmail.com>
	<93FCCE39-FC5B-43F1-B581-76D2AD1660A6@suse.de>
	<201203032117.39190.paul@codesourcery.com>
Date: Sat, 03 Mar 2012 23:08:59 +0100
In-Reply-To: <201203032117.39190.paul@codesourcery.com> (Paul Brook's message
	of "Sat, 3 Mar 2012 21:17:37 +0000")
Message-ID: <m24nu5e3r8.fsf@igel.home>
MIME-Version: 1.0
Content-Type: text/plain
Subject: Re: [Qemu-devel] ARM brk bug
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Paul Brook <paul@codesourcery.com>
Cc: Peter Maydell <peter.maydell@linaro.org>, riku.voipio@iki.fi, Alexander Graf <agraf@suse.de>, "Bernhard M. Wiedemann" <bwiedemann@suse.de>, qemu-devel@nongnu.org

Paul Brook <paul@codesourcery.com> writes:

>> 15545 brk(NULL) = 0x00012000
>> 15545 brk(0x00812000) = 0x00012000
>
> This is your bug.  According to the trace above, the brk call fails, but 
> returns success anyway.  A quick look at do_brk confirms this suspicion.

This is not a bug.  The brk syscall always returns the break value,
either the new one (on success) or the current one (on failure).

Andreas.

-- 
Andreas Schwab, schwab@linux-m68k.org
GPG Key fingerprint = 58CA 54C7 6D53 942B 1756  01D3 44D5 214B 8276 4ED5
"And now for something completely different."