From: Andreas Schwab <schwab@linux-m68k.org>
To: "Kirill A. Shutemov" <kirill@shutemov.name>
Cc: qemu-devel@nongnu.org
Subject: [Qemu-devel] Re: [PATCH 09/18] block/qcow2.c: fix warnings with _FORTIFY_SOURCE
Date: Sun, 20 Dec 2009 10:08:35 +0100 [thread overview]
Message-ID: <m26382f1ws.fsf@igel.home> (raw)
In-Reply-To: <1261273167-3240-9-git-send-email-kirill@shutemov.name> (Kirill A. Shutemov's message of "Sun, 20 Dec 2009 03:39:18 +0200")
"Kirill A. Shutemov" <kirill@shutemov.name> writes:
> lseek(fd, s->refcount_block_offset, SEEK_SET);
> - write(fd, s->refcount_block, ref_clusters * s->cluster_size);
> + ret = write(fd, s->refcount_block, ref_clusters * s->cluster_size);
> + if (ret != s->cluster_size) {
> + ret = -errno;
> + goto exit;
> + }
If you have a short write you'll get an undefined errno.
Andreas.
--
Andreas Schwab, schwab@linux-m68k.org
GPG Key fingerprint = 58CA 54C7 6D53 942B 1756 01D3 44D5 214B 8276 4ED5
"And now for something completely different."
next prev parent reply other threads:[~2009-12-20 9:08 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-12-20 1:39 [Qemu-devel] [PATCH 01/18] Do not disable _FORTIFY_SOURCE Kirill A. Shutemov
2009-12-20 1:39 ` [Qemu-devel] [PATCH 02/18] block.c: fix warning with _FORTIFY_SOURCE Kirill A. Shutemov
2009-12-20 1:39 ` [Qemu-devel] [PATCH 03/18] posix-aio-compat.c: " Kirill A. Shutemov
2009-12-20 1:39 ` [Qemu-devel] [PATCH 04/18] block/cow.c: fix warnings " Kirill A. Shutemov
2009-12-20 1:39 ` [Qemu-devel] [PATCH 05/18] block/qcow.c: " Kirill A. Shutemov
2009-12-20 1:39 ` [Qemu-devel] [PATCH 06/18] block/vmdk.o: " Kirill A. Shutemov
2009-12-20 1:39 ` [Qemu-devel] [PATCH 07/18] block/bochs.c: fix warning " Kirill A. Shutemov
2009-12-20 1:39 ` [Qemu-devel] [PATCH 08/18] block/vvfat.c: fix warnings " Kirill A. Shutemov
2009-12-20 1:39 ` [Qemu-devel] [PATCH 09/18] block/qcow2.c: " Kirill A. Shutemov
2009-12-20 1:39 ` [Qemu-devel] [PATCH 10/18] net/slirp.c: fix warning " Kirill A. Shutemov
2009-12-20 1:39 ` [Qemu-devel] [PATCH 11/18] usb-linux.c: " Kirill A. Shutemov
2009-12-20 1:39 ` [Qemu-devel] [PATCH 12/18] savevm.c: " Kirill A. Shutemov
2009-12-20 1:39 ` [Qemu-devel] [PATCH 13/18] slirp/misc.c: " Kirill A. Shutemov
2009-12-20 1:39 ` [Qemu-devel] [PATCH 14/18] vl.c: " Kirill A. Shutemov
2009-12-20 1:39 ` [Qemu-devel] [PATCH 15/18] monitor.c: fix warnings " Kirill A. Shutemov
2009-12-20 1:39 ` [Qemu-devel] [PATCH 16/18] hw/pc.c: " Kirill A. Shutemov
2009-12-20 1:39 ` [Qemu-devel] [PATCH 17/18] path.c fix warning " Kirill A. Shutemov
2009-12-20 1:39 ` [Qemu-devel] [PATCH 18/18] linux-user/mmap.c: fix warnings " Kirill A. Shutemov
2009-12-22 20:49 ` [Qemu-devel] [PATCH 17/18] path.c fix warning " Blue Swirl
2009-12-22 20:43 ` [Qemu-devel] [PATCH 16/18] hw/pc.c: fix warnings " Blue Swirl
2009-12-22 21:12 ` [Qemu-devel] [PATCH 14/18] vl.c: fix warning " Blue Swirl
2009-12-22 19:21 ` [Qemu-devel] [PATCH 12/18] savevm.c: " Blue Swirl
2009-12-22 19:03 ` [Qemu-devel] [PATCH 11/18] usb-linux.c: " Blue Swirl
2009-12-22 18:50 ` [Qemu-devel] [PATCH 10/18] net/slirp.c: " Blue Swirl
2009-12-20 9:08 ` Andreas Schwab [this message]
2009-12-20 10:48 ` [Qemu-devel] [PATCH 08/18] block/vvfat.c: fix warnings " Kevin Wolf
2009-12-22 21:02 ` [Qemu-devel] [PATCH 07/18] block/bochs.c: fix warning " Blue Swirl
2009-12-20 23:02 ` [Qemu-devel] [PATCH 03/18] posix-aio-compat.c: " Paul Brook
2009-12-22 18:35 ` [Qemu-devel] [PATCH 02/18] block.c: " Blue Swirl
2009-12-20 11:38 ` [Qemu-devel] [PATCH 01/18] Do not disable _FORTIFY_SOURCE Blue Swirl
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=m26382f1ws.fsf@igel.home \
--to=schwab@linux-m68k.org \
--cc=kirill@shutemov.name \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).