From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1NMHmQ-0001nf-Bn
	for qemu-devel@nongnu.org; Sun, 20 Dec 2009 04:08:46 -0500
Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43)
	id 1NMHmL-0001hY-Sg
	for qemu-devel@nongnu.org; Sun, 20 Dec 2009 04:08:45 -0500
Received: from [199.232.76.173] (port=40647 helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1NMHmL-0001gt-NZ
	for qemu-devel@nongnu.org; Sun, 20 Dec 2009 04:08:41 -0500
Received: from mail-out.m-online.net ([212.18.0.10]:48824)
	by monty-python.gnu.org with esmtp (Exim 4.60)
	(envelope-from <whitebox@nefkom.net>) id 1NMHmK-0006J4-N6
	for qemu-devel@nongnu.org; Sun, 20 Dec 2009 04:08:40 -0500
From: Andreas Schwab <schwab@linux-m68k.org>
References: <1261273167-3240-1-git-send-email-kirill@shutemov.name>
	<1261273167-3240-2-git-send-email-kirill@shutemov.name>
	<1261273167-3240-3-git-send-email-kirill@shutemov.name>
	<1261273167-3240-4-git-send-email-kirill@shutemov.name>
	<1261273167-3240-5-git-send-email-kirill@shutemov.name>
	<1261273167-3240-6-git-send-email-kirill@shutemov.name>
	<1261273167-3240-7-git-send-email-kirill@shutemov.name>
	<1261273167-3240-8-git-send-email-kirill@shutemov.name>
	<1261273167-3240-9-git-send-email-kirill@shutemov.name>
Date: Sun, 20 Dec 2009 10:08:35 +0100
In-Reply-To: <1261273167-3240-9-git-send-email-kirill@shutemov.name> (Kirill
	A. Shutemov's message of "Sun, 20 Dec 2009 03:39:18 +0200")
Message-ID: <m26382f1ws.fsf@igel.home>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Subject: [Qemu-devel] Re: [PATCH 09/18] block/qcow2.c: fix warnings with
	_FORTIFY_SOURCE
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: "Kirill A. Shutemov" <kirill@shutemov.name>
Cc: qemu-devel@nongnu.org

"Kirill A. Shutemov" <kirill@shutemov.name> writes:

>      lseek(fd, s->refcount_block_offset, SEEK_SET);
> -    write(fd, s->refcount_block, ref_clusters * s->cluster_size);
> +    ret = write(fd, s->refcount_block, ref_clusters * s->cluster_size);
> +    if (ret != s->cluster_size) {
> +        ret = -errno;
> +        goto exit;
> +    }

If you have a short write you'll get an undefined errno.

Andreas.

-- 
Andreas Schwab, schwab@linux-m68k.org
GPG Key fingerprint = 58CA 54C7 6D53 942B 1756  01D3 44D5 214B 8276 4ED5
"And now for something completely different."