From: Andreas Schwab <schwab@linux-m68k.org>
To: Blue Swirl <blauwirbel@gmail.com>
Cc: qemu-devel <qemu-devel@nongnu.org>
Subject: [Qemu-devel] Re: [PATCH 1/5] HACKING: add preprocessor rules
Date: Sun, 15 Aug 2010 23:27:12 +0200 [thread overview]
Message-ID: <m28w47o9cf.fsf@igel.home> (raw)
In-Reply-To: <AANLkTikzSMQAZHUW+JPHQY1z14TCV1Zvs8qu=w-JzWM-@mail.gmail.com> (Blue Swirl's message of "Sun, 15 Aug 2010 17:50:07 +0000")
Blue Swirl <blauwirbel@gmail.com> writes:
> +For variadic macros, stick with C99 syntax:
> +
> +#define DPRINTF(fmt, ...) \
> + do { printf("IRQ: " fmt, ## __VA_ARGS__); } while (0)
That's not C99 syntax, the combination with ## is a gcc extension. In
C99 you cannot have an empty __VA_ARGS__.
Andreas.
--
Andreas Schwab, schwab@linux-m68k.org
GPG Key fingerprint = 58CA 54C7 6D53 942B 1756 01D3 44D5 214B 8276 4ED5
"And now for something completely different."
next prev parent reply other threads:[~2010-08-15 21:27 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-08-15 17:50 [Qemu-devel] [PATCH 1/5] HACKING: add preprocessor rules Blue Swirl
2010-08-15 21:27 ` Andreas Schwab [this message]
2010-08-16 18:05 ` [Qemu-devel] " Blue Swirl
2010-08-16 18:32 ` Anthony Liguori
2010-08-17 17:40 ` Blue Swirl
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=m28w47o9cf.fsf@igel.home \
--to=schwab@linux-m68k.org \
--cc=blauwirbel@gmail.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).