From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from [140.186.70.92] (port=52151 helo=eggs.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1Okkjg-0004LG-CV
	for qemu-devel@nongnu.org; Sun, 15 Aug 2010 17:27:25 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.69)
	(envelope-from <whitebox@nefkom.net>) id 1Okkjb-0004It-DR
	for qemu-devel@nongnu.org; Sun, 15 Aug 2010 17:27:20 -0400
Received: from mail-out.m-online.net ([212.18.0.10]:60038)
	by eggs.gnu.org with esmtp (Exim 4.69)
	(envelope-from <whitebox@nefkom.net>) id 1Okkjb-0004If-6R
	for qemu-devel@nongnu.org; Sun, 15 Aug 2010 17:27:15 -0400
From: Andreas Schwab <schwab@linux-m68k.org>
References: <AANLkTikzSMQAZHUW+JPHQY1z14TCV1Zvs8qu=w-JzWM-@mail.gmail.com>
Date: Sun, 15 Aug 2010 23:27:12 +0200
In-Reply-To: <AANLkTikzSMQAZHUW+JPHQY1z14TCV1Zvs8qu=w-JzWM-@mail.gmail.com>
	(Blue Swirl's message of "Sun, 15 Aug 2010 17:50:07 +0000")
Message-ID: <m28w47o9cf.fsf@igel.home>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Subject: [Qemu-devel] Re: [PATCH 1/5] HACKING: add preprocessor rules
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Blue Swirl <blauwirbel@gmail.com>
Cc: qemu-devel <qemu-devel@nongnu.org>

Blue Swirl <blauwirbel@gmail.com> writes:

> +For variadic macros, stick with C99 syntax:
> +
> +#define DPRINTF(fmt, ...)                                       \
> +    do { printf("IRQ: " fmt, ## __VA_ARGS__); } while (0)

That's not C99 syntax, the combination with ## is a gcc extension.  In
C99 you cannot have an empty __VA_ARGS__.

Andreas.

-- 
Andreas Schwab, schwab@linux-m68k.org
GPG Key fingerprint = 58CA 54C7 6D53 942B 1756  01D3 44D5 214B 8276 4ED5
"And now for something completely different."