Re: [PATCH v3 3/4] fuzz: fix the AC97 generic-fuzzer config.

[Darren Kenny <darren.kenny@oracle.com>]

Hi Alex,

Given that 2 of the patches here are simply adding a capitalized version
of the string, I wonder if this is something that should be case
insensitive, and thus the code should change instead?

Hypothetically, how likely is it that there are unrelated objects with
the same name but different case in the name?

Isn't it more likely to be that any object with the same name, despite
the case, is the same object?

Thanks,

Darren.

On Wednesday, 2021-06-23 at 23:45:02 -04, Alexander Bulekov wrote:
> TYPE_AC97 is "AC97", capitalized. Fix the config to account for that.
>
> Signed-off-by: Alexander Bulekov <alxndr@bu.edu>
> ---
>  tests/qtest/fuzz/generic_fuzz_configs.h | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/tests/qtest/fuzz/generic_fuzz_configs.h b/tests/qtest/fuzz/generic_fuzz_configs.h
> index 004c701915..049697b974 100644
> --- a/tests/qtest/fuzz/generic_fuzz_configs.h
> +++ b/tests/qtest/fuzz/generic_fuzz_configs.h
> @@ -218,7 +218,7 @@ const generic_fuzz_config predefined_configs[] = {
>          .name = "ac97",
>          .args = "-machine q35 -nodefaults "
>          "-device ac97,audiodev=snd0 -audiodev none,id=snd0 -nodefaults",
> -        .objects = "ac97*",
> +        .objects = "ac97* AC97",
>      },{
>          .name = "cs4231a",
>          .args = "-machine q35 -nodefaults "
> -- 
> 2.28.0