From: MORITA Kazutaka <morita.kazutaka@gmail.com>
To: Kevin Wolf <kwolf@redhat.com>
Cc: "Peter Maydell" <peter.maydell@linaro.org>,
"Anthony Liguori" <aliguori@us.ibm.com>,
patches@linaro.org, qemu-devel@nongnu.org,
"Alexander Graf" <agraf@suse.de>,
"Andreas Färber" <andreas.faerber@web.de>,
qemu-ppc@nongnu.org, "Stefan Hajnoczi" <stefanha@redhat.com>,
"Paolo Bonzini" <pbonzini@redhat.com>,
morita.kazutaka@lab.ntt.co.jp,
"Richard Henderson" <rth@twiddle.net>
Subject: Re: [Qemu-devel] [PATCH 1/4] block/sheepdog: Rename 'dprintf' to 'DPRINTF'
Date: Tue, 30 Jul 2013 08:39:30 +0900 [thread overview]
Message-ID: <m2bo5ley19.wl%morita.kazutaka@gmail.com> (raw)
In-Reply-To: <20130729124416.GC10467@dhcp-200-207.str.redhat.com>
At Mon, 29 Jul 2013 14:44:16 +0200,
Kevin Wolf wrote:
>
> Am 29.07.2013 um 14:16 hat Peter Maydell geschrieben:
> > 'dprintf' is the name of a POSIX standard function so we should not be
> > stealing it for our debug macro. Rename to 'DPRINTF' (in line with
> > a number of other source files.)
> >
> > Signed-off-by: Peter Maydell <peter.maydell@linaro.org>
>
> Acked-by: Kevin Wolf <kwolf@redhat.com>
>
> (CCed Kazutaka in case he has any objections, unexpectedly)
No problem.
Reviewed-by: MORITA Kazutaka <morita.kazutaka@lab.ntt.co.jp>
Thanks,
Kazutaka
next prev parent reply other threads:[~2013-07-29 23:39 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-07-29 12:16 [Qemu-devel] [PATCH 0/4] Rename all 'dprintf' macros to 'DPRINTF' Peter Maydell
2013-07-29 12:16 ` [Qemu-devel] [PATCH 1/4] block/sheepdog: Rename 'dprintf' " Peter Maydell
2013-07-29 12:44 ` Kevin Wolf
2013-07-29 23:39 ` MORITA Kazutaka [this message]
2013-07-29 12:16 ` [Qemu-devel] [PATCH 2/4] s390x: " Peter Maydell
2013-07-29 12:16 ` [Qemu-devel] [PATCH 3/4] target-ppc/kvm.c: " Peter Maydell
2013-07-29 12:16 ` [Qemu-devel] [PATCH 4/4] spapr: " Peter Maydell
2013-07-29 16:38 ` [Qemu-devel] [PATCH 0/4] Rename all 'dprintf' macros " Richard Henderson
2013-07-29 17:34 ` Andreas Färber
2013-08-02 12:35 ` Anthony Liguori
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=m2bo5ley19.wl%morita.kazutaka@gmail.com \
--to=morita.kazutaka@gmail.com \
--cc=agraf@suse.de \
--cc=aliguori@us.ibm.com \
--cc=andreas.faerber@web.de \
--cc=kwolf@redhat.com \
--cc=morita.kazutaka@lab.ntt.co.jp \
--cc=patches@linaro.org \
--cc=pbonzini@redhat.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
--cc=qemu-ppc@nongnu.org \
--cc=rth@twiddle.net \
--cc=stefanha@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).