From: Darren Kenny <darren.kenny@oracle.com>
To: Alexander Bulekov <alxndr@bu.edu>, qemu-devel@nongnu.org
Cc: Alexander Bulekov <alxndr@bu.edu>,
Stefan Hajnoczi <stefanha@redhat.com>,
Bandan Das <bsd@redhat.com>, Paolo Bonzini <pbonzini@redhat.com>,
Thomas Huth <thuth@redhat.com>, Qiuhao Li <Qiuhao.Li@outlook.com>,
Laurent Vivier <lvivier@redhat.com>
Subject: Re: [PATCH 07/10] fuzz/virtio-blk: remove fork-based fuzzer
Date: Mon, 13 Feb 2023 14:45:07 +0000 [thread overview]
Message-ID: <m2cz6dr5e4.fsf@oracle.com> (raw)
In-Reply-To: <20230205042951.3570008-8-alxndr@bu.edu>
On Saturday, 2023-02-04 at 23:29:48 -05, Alexander Bulekov wrote:
> Signed-off-by: Alexander Bulekov <alxndr@bu.edu>
Reviewed-by: Darren Kenny <darren.kenny@oracle.com>
Thanks,
Darren.
> ---
> tests/qtest/fuzz/virtio_blk_fuzz.c | 51 ++++--------------------------
> 1 file changed, 7 insertions(+), 44 deletions(-)
>
> diff --git a/tests/qtest/fuzz/virtio_blk_fuzz.c b/tests/qtest/fuzz/virtio_blk_fuzz.c
> index a9fb9ecf6c..82575a11d9 100644
> --- a/tests/qtest/fuzz/virtio_blk_fuzz.c
> +++ b/tests/qtest/fuzz/virtio_blk_fuzz.c
> @@ -19,7 +19,6 @@
> #include "standard-headers/linux/virtio_pci.h"
> #include "standard-headers/linux/virtio_blk.h"
> #include "fuzz.h"
> -#include "fork_fuzz.h"
> #include "qos_fuzz.h"
>
> #define TEST_IMAGE_SIZE (64 * 1024 * 1024)
> @@ -128,48 +127,24 @@ static void virtio_blk_fuzz(QTestState *s, QVirtioBlkQueues* queues,
> }
> }
>
> -static void virtio_blk_fork_fuzz(QTestState *s,
> - const unsigned char *Data, size_t Size)
> -{
> - QVirtioBlk *blk = fuzz_qos_obj;
> - static QVirtioBlkQueues *queues;
> - if (!queues) {
> - queues = qvirtio_blk_init(blk->vdev, 0);
> - }
> - if (fork() == 0) {
> - virtio_blk_fuzz(s, queues, Data, Size);
> - flush_events(s);
> - _Exit(0);
> - } else {
> - flush_events(s);
> - wait(NULL);
> - }
> -}
> -
> static void virtio_blk_with_flag_fuzz(QTestState *s,
> const unsigned char *Data, size_t Size)
> {
> QVirtioBlk *blk = fuzz_qos_obj;
> static QVirtioBlkQueues *queues;
>
> - if (fork() == 0) {
> - if (Size >= sizeof(uint64_t)) {
> - queues = qvirtio_blk_init(blk->vdev, *(uint64_t *)Data);
> - virtio_blk_fuzz(s, queues,
> - Data + sizeof(uint64_t), Size - sizeof(uint64_t));
> - flush_events(s);
> - }
> - _Exit(0);
> - } else {
> + if (Size >= sizeof(uint64_t)) {
> + queues = qvirtio_blk_init(blk->vdev, *(uint64_t *)Data);
> + virtio_blk_fuzz(s, queues,
> + Data + sizeof(uint64_t), Size - sizeof(uint64_t));
> flush_events(s);
> - wait(NULL);
> }
> + fuzz_reboot(s);
> }
>
> static void virtio_blk_pre_fuzz(QTestState *s)
> {
> qos_init_path(s);
> - counter_shm_init();
> }
>
> static void drive_destroy(void *path)
> @@ -208,22 +183,10 @@ static void *virtio_blk_test_setup(GString *cmd_line, void *arg)
>
> static void register_virtio_blk_fuzz_targets(void)
> {
> - fuzz_add_qos_target(&(FuzzTarget){
> - .name = "virtio-blk-fuzz",
> - .description = "Fuzz the virtio-blk virtual queues, forking "
> - "for each fuzz run",
> - .pre_vm_init = &counter_shm_init,
> - .pre_fuzz = &virtio_blk_pre_fuzz,
> - .fuzz = virtio_blk_fork_fuzz,},
> - "virtio-blk",
> - &(QOSGraphTestOptions){.before = virtio_blk_test_setup}
> - );
> -
> fuzz_add_qos_target(&(FuzzTarget){
> .name = "virtio-blk-flags-fuzz",
> - .description = "Fuzz the virtio-blk virtual queues, forking "
> - "for each fuzz run (also fuzzes the virtio flags)",
> - .pre_vm_init = &counter_shm_init,
> + .description = "Fuzz the virtio-blk virtual queues. "
> + "Also fuzzes the virtio flags)",
> .pre_fuzz = &virtio_blk_pre_fuzz,
> .fuzz = virtio_blk_with_flag_fuzz,},
> "virtio-blk",
> --
> 2.39.0
next prev parent reply other threads:[~2023-02-13 14:45 UTC|newest]
Thread overview: 36+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-02-05 4:29 [PATCH 00/10] Retire Fork-Based Fuzzing Alexander Bulekov
2023-02-05 4:29 ` [PATCH 01/10] hw/sparse-mem: clear memory on reset Alexander Bulekov
2023-02-05 10:40 ` Philippe Mathieu-Daudé
2023-02-13 14:15 ` Darren Kenny
2023-02-05 4:29 ` [PATCH 02/10] fuzz: add fuzz_reboot API Alexander Bulekov
2023-02-05 10:50 ` Philippe Mathieu-Daudé
2023-02-13 14:19 ` Darren Kenny
2023-02-05 4:29 ` [PATCH 03/10] fuzz/generic-fuzz: use reboots instead of forks to reset state Alexander Bulekov
2023-02-13 14:26 ` Darren Kenny
2023-02-17 4:01 ` Alexander Bulekov
2023-02-05 4:29 ` [PATCH 04/10] fuzz/generic-fuzz: add a limit on DMA bytes written Alexander Bulekov
2023-02-05 10:42 ` Philippe Mathieu-Daudé
2023-02-13 14:38 ` Darren Kenny
2023-02-17 3:59 ` Alexander Bulekov
2023-02-05 4:29 ` [PATCH 05/10] fuzz/virtio-scsi: remove fork-based fuzzer Alexander Bulekov
2023-02-13 14:42 ` Darren Kenny
2023-02-05 4:29 ` [PATCH 06/10] fuzz/virtio-net: " Alexander Bulekov
2023-02-13 14:44 ` Darren Kenny
2023-02-05 4:29 ` [PATCH 07/10] fuzz/virtio-blk: " Alexander Bulekov
2023-02-13 14:45 ` Darren Kenny [this message]
2023-02-05 4:29 ` [PATCH 08/10] fuzz/i440fx: " Alexander Bulekov
2023-02-13 14:46 ` Darren Kenny
2023-02-05 4:29 ` [PATCH 09/10] fuzz: remove fork-fuzzing scaffolding Alexander Bulekov
2023-02-13 14:47 ` Darren Kenny
2023-02-05 4:29 ` [PATCH 10/10] docs/fuzz: remove mentions of fork-based fuzzing Alexander Bulekov
2023-02-13 14:48 ` Darren Kenny
2023-02-05 10:39 ` [PATCH 00/10] Retire Fork-Based Fuzzing Philippe Mathieu-Daudé
2023-02-06 14:09 ` Alexander Bulekov
2023-02-13 2:11 ` Alexander Bulekov
2023-02-14 15:38 ` Stefan Hajnoczi
2023-02-14 16:08 ` Philippe Mathieu-Daudé
2023-02-14 17:58 ` Laurent Vivier
2023-02-14 18:46 ` Stefan Hajnoczi
2023-02-14 19:09 ` Thomas Huth
2023-02-14 19:14 ` Alexander Bulekov
2023-02-14 21:08 ` Thomas Huth
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=m2cz6dr5e4.fsf@oracle.com \
--to=darren.kenny@oracle.com \
--cc=Qiuhao.Li@outlook.com \
--cc=alxndr@bu.edu \
--cc=bsd@redhat.com \
--cc=lvivier@redhat.com \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=stefanha@redhat.com \
--cc=thuth@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).